Skip to content

Removed RequiredModules from xPhpProvision, fixes PowerShell/xPhp#7. - #8

Open
remcoeissing wants to merge 2 commits into
dsccommunity:devfrom
remcoeissing:dev
Open

Removed RequiredModules from xPhpProvision, fixes PowerShell/xPhp#7.#8
remcoeissing wants to merge 2 commits into
dsccommunity:devfrom
remcoeissing:dev

Conversation

@remcoeissing

@remcoeissing remcoeissing commented Apr 30, 2017

Copy link
Copy Markdown
  • Removed RequiredModules from xPhpProvision. As this resulted in the xPhpProvision resource not loading. This fixes Can't get any version of this to work. #7.
  • Introduced integration test
  • Cleanup code.
  • Reformatted Readme.md
  • Added MetaTestOptIn.json.

This change is Reviewable

Introduced integration test, cleanup code.
@johlju

johlju commented May 16, 2018

Copy link
Copy Markdown
Member

@remcoeissing sorry that nobody responded for so long. Do you have time to work on this PR if I review it?

@johlju johlju added the waiting for author response The pull request is waiting for the author to respond to comments in the pull request. label May 16, 2018
@stale

stale Bot commented Jun 18, 2018

Copy link
Copy Markdown

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

@stale stale Bot added the abandoned The pull request has been abandoned. label Jun 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

abandoned The pull request has been abandoned. waiting for author response The pull request is waiting for the author to respond to comments in the pull request.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can't get any version of this to work.

5 participants