Skip to content

Improve mobile navigation contrast in dark mode#3879

Open
h1a2r3s4h wants to merge 2 commits intodubinc:mainfrom
h1a2r3s4h:fix-mobile-darkmode-nav-contrast
Open

Improve mobile navigation contrast in dark mode#3879
h1a2r3s4h wants to merge 2 commits intodubinc:mainfrom
h1a2r3s4h:fix-mobile-darkmode-nav-contrast

Conversation

@h1a2r3s4h
Copy link
Copy Markdown

@h1a2r3s4h h1a2r3s4h commented May 9, 2026

Summary

Improves readability of mobile navigation menu items in dark mode on the /brand page.

Changes

  • Increased contrast of solution description text in dark mode
  • Updated dark:text-white/60 to dark:text-white/80

Issue

Menu items appeared too dim on dark backgrounds, reducing readability on mobile devices.

Summary by CodeRabbit

  • Style

    • Improved dark mode contrast for card descriptions
    • Prevented navigation button text from wrapping on smaller screens
  • Chores

    • Updated database port configuration in local development environment

Review Change Stack

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 9, 2026

@h1a2r3s4h is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ef383f39-07be-45c0-855c-4daac90e3eaa

📥 Commits

Reviewing files that changed from the base of the PR and between a5fa025 and bcc43d2.

📒 Files selected for processing (3)
  • apps/web/docker-compose.yml
  • packages/ui/src/nav/content/solutions-content.tsx
  • packages/ui/src/nav/nav.tsx

📝 Walkthrough

Walkthrough

This PR makes three independent cosmetic and configuration updates: it adjusts the Docker Compose MySQL port binding from 3306 to 3307 on the host, adds text wrapping prevention to three navigation action buttons, and increases dark-mode text contrast in a solutions content card description.

Changes

Infrastructure Configuration

Layer / File(s) Summary
Docker Service Ports
apps/web/docker-compose.yml
MySQL service host-to-container port mapping changed from 3306:3306 to 3307:3306.

Navigation UI Styling

Layer / File(s) Summary
Action Links Text Wrapping
packages/ui/src/nav/nav.tsx
Dashboard, Log in, and Sign up buttons each add whitespace-nowrap class to prevent text wrapping.
Solutions Content Contrast
packages/ui/src/nav/content/solutions-content.tsx
Card description paragraph dark-mode text opacity increased from dark:text-white/60 to dark:text-white/80.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A port shifts from three-oh-six, so keen,
while buttons learn to hold their lines tight,
and dark text glows a touch more bright—
small touches make the UI clean and lean!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Title check ⚠️ Warning The title 'Improve mobile navigation contrast in dark mode' aligns with the main purpose of the PR (addressing dark mode readability), but the changeset includes unrelated modifications to Docker Compose MySQL port mapping (3306→3307) that are not addressed in the title. Either update the title to reflect all changes (e.g., 'Improve mobile navigation contrast in dark mode and update MySQL port mapping'), or remove the unrelated Docker Compose change from this PR.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants