Merged
Conversation
dyaa
reviewed
May 6, 2024
Comment on lines
38
to
39
| validateSubjectAltName: boolean, | ||
| options: Partial<https.RequestOptions> = {} |
Owner
There was a problem hiding this comment.
Let's keep validateSubjectAltName part of the options instead of having own parameter?
Contributor
Author
There was a problem hiding this comment.
@dyaa - Not sure I follow - this is a custom boolean config - Are you saying to change the logic to make the https request itself different depending on that flag? Currently I'm only using the flag post http request to decide whether to validate subjectaltname response or not.
Contributor
Author
There was a problem hiding this comment.
See latest commit - I've moved the logic into the http request/response itself - does that work?
Owner
|
Fixes #538 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added additional config option to choose if the
subjectaltnameshould be required for a given certificate to be valid, since it is an optional field to configure within a certificate. Allows for more flexibility to validate certificates without this configured.