This repository was archived by the owner on Apr 26, 2024. It is now read-only.
add show_package_total option#2212
Closed
PauloGDPeixoto wants to merge 2 commits intodylanaraps:masterfrom
PauloGDPeixoto:add-show_package_tot-option
Closed
add show_package_total option#2212PauloGDPeixoto wants to merge 2 commits intodylanaraps:masterfrom PauloGDPeixoto:add-show_package_tot-option
PauloGDPeixoto wants to merge 2 commits intodylanaraps:masterfrom
PauloGDPeixoto:add-show_package_tot-option
Conversation
jinasanami
added a commit
to nmimusic/unifetch
that referenced
this pull request
Oct 11, 2022
|
Wow, it works well on Univalent GNU/Linux!
|
|
Oops, I forgot to attach the image what I turned off the option. |
|
|
||
| elif [[ $package_managers == tiny ]]; then | ||
| packages+=" (${manager_string%,*})" | ||
| if [[ $show_package_total == "on" ]]; then |
There was a problem hiding this comment.
It would be much better to return early if $show_package_total == "off" rather than re-indent the entire function
|
This feature already exists in neofetch. You can use
You can also turn off package manager detection by editing the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I found that the package count was degrading the performance of neofetch in my machines, so I added a parameter to optionally disable this particular output.
Features
Add --show_package_total flag to enable/disable the package count display in neofetch.