Feature/improve entity files endpoints#63
Merged
Conversation
…ion for entity files
…generation methods
…ile details retrieval
…ntityFileStorageController
…or simple-file-server
…anagement commands
…e simple-file-server instance
…ty with Fastify v5 feat: add integration tests for RemoteEntityFileStorage functionality
…n resource fetching
There was a problem hiding this comment.
Pull request overview
This PR performs a coordinated version bump of the Dynamia Tools framework from 26.4.1 to 26.5.0 across the Maven multi-module reactor and the JavaScript/TypeScript workspace packages, and introduces a few small framework-level additions. The PR title ("improve entity files endpoints") suggests entity-file endpoint improvements as the underlying motivation — the parent POM gains an AWS SDK bump and a new minio.version property — but the visible diffs do not include the endpoint code itself (likely truncated).
Changes:
- Bump parent/module versions
26.4.1 → 26.5.0across allpom.xmland JS/TSpackage.json/lock files; bumpaws.versionto2.44.5and addminio.version=8.5.17in the parent POM. - Fix
FormViewRenderer.renderRowsso grouped fields are no longer rendered twice (once ungrouped, once in their group), and addloadParams/loadHeadershelpers toHttpUtils. - Add
SimpleEntity.currentVersion()accessor for the JPA@Versionfield; addContainersimport inSaveConfigAction; tweakpnpm-workspace.yaml(sharp: false).
Reviewed changes
Copilot reviewed 108 out of 112 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| pom.xml | Parent version bump; AWS SDK bumped, minio.version property added (no consumer in this diff). |
| themes/pom.xml, themes/theme-dynamical/sources/pom.xml | Parent and tools.dynamia.zk dependency version bumps. |
| platform/core/**/pom.xml (domain, domain-jpa, integration, io, navigation, reports, templates, viewers, web) | Parent and intra-project dependency version bumps. |
| platform/ui/ui-shared/pom.xml, platform/ui/zk/pom.xml | Parent and intra-project dependency version bumps. |
| platform/starters/zk-starter/pom.xml | Parent and intra-project dependency version bumps. |
| platform/packages/{sdk,cli,vue,ui-core}/package.json + lockfiles | JS/TS package version bumps to 26.5.0. |
| pnpm-workspace.yaml | Sets allowBuilds.sharp: false; cosmetic blank-line removal. |
| platform/core/domain-jpa/.../SimpleEntity.java | Adds non-bean currentVersion() accessor with a typo in Javadoc. |
| platform/core/web/.../HttpUtils.java | Adds loadParams and loadHeaders utilities (lossy: single value per key, case-sensitive headers). |
| platform/ui/zk/.../viewers/form/FormViewRenderer.java | Guards ungrouped-field rendering with field.getGroup() == null to avoid duplicate rendering; Javadoc whitespace alignment. |
| platform/ui/zk/.../crud/cfg/SaveConfigAction.java | Adds Containers import (consumer presumably in unshown diff). |
Files not reviewed (3)
- platform/packages/cli/package-lock.json: Language not supported
- platform/packages/sdk/package-lock.json: Language not supported
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
platform/core/web/src/main/java/tools/dynamia/web/util/HttpUtils.java:452
loadHeaderskeeps only a single value per header name and is case-sensitive in the resultingHashMap, even though HTTP header names are case-insensitive and may legitimately appear multiple times (e.g.Set-Cookie,Accept). Consider returningMap<String, List<String>>(viarequest.getHeaders(name)) and/or using a case-insensitive map such asTreeMapwithString.CASE_INSENSITIVE_ORDER, so callers can reliably look up headers without losing data.
| } | ||
|
|
||
| /** | ||
| * Generic getter to query curent entity version |
Comment on lines
+89
to
+91
| public int currentVersion() { | ||
| return version; | ||
| } |
Comment on lines
+432
to
+438
| public static Map<String, String> loadParams(HttpServletRequest request) { | ||
| Map<String, String> params = new HashMap<>(); | ||
| request.getParameterNames().asIterator().forEachRemaining(name -> { | ||
| params.put(name, request.getParameter(name)); | ||
| }); | ||
| return params; | ||
| } |
Comment on lines
+427
to
+441
| * Load request parameters in to map | ||
| * | ||
| * @param request request | ||
| * @return parameters map | ||
| */ | ||
| public static Map<String, String> loadParams(HttpServletRequest request) { | ||
| Map<String, String> params = new HashMap<>(); | ||
| request.getParameterNames().asIterator().forEachRemaining(name -> { | ||
| params.put(name, request.getParameter(name)); | ||
| }); | ||
| return params; | ||
| } | ||
|
|
||
| /** | ||
| * Load request headers in to a map |
Comment on lines
+67
to
+68
| <aws.version>2.44.5</aws.version> | ||
| <minio.version>8.5.17</minio.version> |
Comment on lines
99
to
152
| @@ -134,19 +134,19 @@ | |||
| <dependency> | |||
| <groupId>tools.dynamia</groupId> | |||
| <artifactId>tools.dynamia.crud</artifactId> | |||
| <version>26.4.1</version> | |||
| <version>26.5.0</version> | |||
| </dependency> | |||
|
|
|||
| <dependency> | |||
| <groupId>tools.dynamia</groupId> | |||
| <artifactId>tools.dynamia.reports</artifactId> | |||
| <version>26.4.1</version> | |||
| <version>26.5.0</version> | |||
| <scope>compile</scope> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>tools.dynamia</groupId> | |||
| <artifactId>tools.dynamia.templates</artifactId> | |||
| <version>26.4.1</version> | |||
| <version>26.5.0</version> | |||
| <scope>compile</scope> | |||
| </dependency> | |||
|
|
|||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.