fix: resolve TypeScript errors and improve type safety in test files#15
Merged
Conversation
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix undefined checks in src/parsers/roo.test.ts - Add missing geminicli property in src/types/index.test.ts - Fix mock types in src/utils/file.test.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix undefined checks in src/parsers/geminicli.test.ts - Fix undefined checks in src/parsers/claudecode.test.ts - Fix undefined checks in src/parsers/cline.test.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add missing geminicli property to mockConfig in add.test.ts and generate.test.ts - Fix type annotations for mockRules and mockOutputs in generate.test.ts - Add missing beforeEach and afterEach imports in import.test.ts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fixed linting errors in src/utils/file.test.ts (replaced 3 'any' types with 'unknown') - Fixed 80 undefined rule errors in src/parsers/cursor.test.ts using null assertion operators - Fixed type compatibility issues in multiple generator and MCP test files - Fixed import issues by changing from default to namespace imports for Node.js modules - Fixed missing 'beforeEach' import in validator.test.ts - Reduced total errors from 293 to 203 and from 22 to 19 files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reduced TypeScript errors from 203 to 112 by adding non-null assertions after array access in test files where length is already verified. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Updated Config interface usage in test files from old properties (projectName, rulesDir) to new properties (aiRulesDir, watchEnabled, defaultTargets) - Fixed null safety issues by adding optional chaining (?.) to array access in test assertions - Fixed type casting for file.test.ts readdir mock from string[] to any to match actual fs.readdir behavior - Reduced TypeScript errors from 112 to 92 across 5 test files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix linting errors in file.test.ts by replacing 'as any' with 'as never' - Fix TypeScript errors in geminicli.test.ts by adding non-null assertions and proper type casting - Fix TypeScript errors in roo.test.ts by adding non-null assertions and proper type casting - Update target names from 'claude' to 'claudecode' to match ToolTarget type definition - Reduce TypeScript errors from 92 to 53 across 3 files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add non-null assertions to array access patterns in test files - Fix type compatibility issues with ToolTarget[] arrays - Update mock configurations to include missing properties - Resolve 53 TypeScript errors across 9 test files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Remove 'as any' type assertions from test files - Add proper ToolTarget type imports and assertions - Fix TypeScript compatibility issues in test configurations - Remove unnecessary 'as const' modifiers causing readonly conflicts 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR resolves TypeScript errors in test and generator files by updating import paths, adding type annotations and non-null assertions, and refining array assignments.
- Updated ESM import paths to include
.jsextensions and added missingimport typestatements. - Cast resolved values and arrays (e.g.,
as never,as ToolTarget[]) to satisfy strict typing. - Added non-null (
!) and optional chaining (?.) assertions in tests to prevent TS errors on possibly undefined values.
Reviewed Changes
Copilot reviewed 34 out of 35 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/utils/file.test.ts | Cast mockReaddir.mockResolvedValue to never to satisfy TS. |
| src/parsers/roo.test.ts | Switched some assertions to use optional chaining (?.) for safety. |
| src/generators/mcp/cline.test.ts | Added import type { ToolTarget } from ../../types/index.js. |
Comments suppressed due to low confidence (1)
src/generators/mcp/cline.test.ts:2
- The
ToolTargettype is defined intypes/rules.js, nottypes/index.js. Update the import toimport type { ToolTarget } from "../../types/rules.js";to avoid import errors.
import type { ToolTarget } from "../../types/index.js";
Comment on lines
+45
to
+51
| expect(result.rules[0]?.frontmatter).toEqual({ | ||
| root: false, | ||
| targets: ["roo"], | ||
| description: "Roo Code instructions", | ||
| globs: ["**/*"], | ||
| }); | ||
| expect(result.rules[0].content).toContain("This is a React TypeScript project"); | ||
| expect(result.rules[0]?.content).toContain("This is a React TypeScript project"); |
There was a problem hiding this comment.
[nitpick] Tests mix optional chaining (?.) and non-null assertions (!). Consider standardizing on one approach (e.g., using ! when you know the value must be present) for consistent readability across all parser tests.
dyoshikawa
changed the title
2 tasks
8 tasks
dyoshikawa
added a commit
that referenced
this pull request
Apr 29, 2026
…ode/cline/qwencode Addresses 18 reviewer findings raised on PR #1338. Highlights: - #1 (critical): AugmentCode non-bash categories now fail-closed. A single deny rule in `read`/`edit`/`write`/`webfetch`/`websearch` collapses the whole tool to a catch-all `deny` entry; non-`*` allow/ask patterns are dropped with an aggregated warning instead of being silently downgraded to a catch-all `allow` that would shadow a deny. - #2 (high): `toolPermissions` are sorted to make AugmentCode's first-match-wins evaluation safe — entries with `shellInputRegex` come before catch-alls, longer regex first, with deny < ask-user < allow as the tiebreaker. - #5 (mid): existing `launch-process` deny entries are preserved across regeneration so a user-added shell deny rule cannot be silently downgraded; non-deny launch-process entries are still owned by rulesync. - #3 (mid): Qwencode generation uses `readFileContentOrNull` (no `readOrInitializeFileContent`) so dry-run does not create the `.qwen/` directory. - #4 (mid): Kilo schema parsing is deferred and respects `params.validate`, so `forDeletion` and dry-run construction never throw on permissive input. - #7, #16 (mid/low): Cline drops non-bash / ask rules at `logger.error` level (rather than warn) and surfaces a defensive warn on allow/deny pattern collisions. - #8, #13 (mid/low): Qwencode pattern parser uses the LAST `)` so nested parentheses (e.g. `Bash(echo (a))`) round-trip; malformed entries warn and fall back to `*`. - #9 (low): Augment non-bash warnings are aggregated once per category. - #11 (low): Kilo's wholesale-replace of the `permission` object is documented in `docs/reference/file-formats.md`. - #10, #6 (low): glob→regex behaviour and round-trip caveats are documented. - #14 (low): `mergedPermissions` is typed as `{ allow?: string[]; ask?: string[]; deny?: string[]; [k: string]: unknown }`. - #15 (low): redundant Qwencode global-mode equivalence assert removed. - #17 (low): `permissions-processor.test.ts` gains `loadToolFiles` cases for AugmentCode, Cline, Kilo, and Qwencode. Deferred: - #12 (kilo home-mock migration): the existing kilo global-mode test already passes `outputRoot` directly and does not reach `getHomeDirectory()`, so introducing the home-mock pattern adds only ceremony without coverage. - #18 (tool-name-mapping helper extraction): postponed to keep this fix focused and to avoid touching files outside the permissions feature. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
as anywith specific type assertionsgeminiclitool target in test configurationsChanges
ConfigandToolTargettypes to mock objectsimport path from "node:path"toimport * as path from "node:path"as constwith proper typed arrays (as ["*"],as ToolTarget[])\!operator instead of?.where values are guaranteed to existgeminiclito configuration objects and target arraysTesting
🤖 Generated with Claude Code