fix(codexcli-mcp): tighten envVars handling#1637
Open
sirmacik wants to merge 1 commit into
Open
Conversation
Contributor
|
Thank you for your contribution! Unfortunately, you currently have 5 open PRs (including this one), which exceeds the limit of 2 for external contributors. Please wait for an existing PR to be reviewed/merged, or close one before opening a new one. See CONTRIBUTING.md for details. |
b52e1eb to
5abb995
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Draft follow-up for #1625. This tightens Codex MCP
envVarshandling and prevents rulesync-only source fields from leaking into Codex output.Changes
RulesyncMcp.getMcpServers()stripped output, then re-merge only valid codex-specificenvVarsfrom the raw source.enabledTools/disabledTools/envVars.env_vars,enabled_tools, anddisabled_toolsarrays when importing Codex TOML.envVarsentries as environment variable names in the Rulesync MCP schema.env_varsbut stripstargets,description, andexposed.skills/rulesyncdocs.Fixes #1625.
Verification
pnpm test src/features/mcp/codexcli-mcp.test.ts src/types/mcp.test.tspnpm cicheckDeferred
Two cross-generator follow-ups from #1625 are intentionally deferred to keep this PR focused:
targets.envVars/targets/description/exposedstripping.Those are valuable, but they touch broader generator behavior and should stay separate from the Codex-specific cleanup.
Review notes
Opened as draft to signal ownership and keep the maintainer-scrap follow-up visible while avoiding immediate review pressure.