refactor(copilot-rule): reuse toPosixPath and switch sameRelativePath to object params#1644
Open
Chen17-sq wants to merge 1 commit into
Open
Conversation
… to object params Addresses the review findings tracked in dyoshikawa#1603: - Replace the local backslash regex with the shared toPosixPath utility, keeping the consecutive-slash collapse and explaining the WSL edge case it covers - Rename the parameter from path to p to avoid shadowing the node:path import - Move sameRelativePath from four positional strings to {dir, file} objects per the coding guidelines and update both call sites - Add forDeletion tests that pin down root detection with a trailing backslash separator and confirm non-root paths with mid-path backslashes stay non-root Refs dyoshikawa#1603.
This was referenced May 16, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses the refactor checklist in #1603 for
src/features/rules/copilot-rule.ts:path.replace(/\\/g, "/")with the sharedtoPosixPathutility fromsrc/utils/file.ts, in line with the coding guideline that points totoPosixPathfor non-filesystem path normalization.replace(/\/+/g, "/")is still needed: on POSIX,node:path.join(".github\\", "x.md")keeps the trailing backslash literal, so aftertoPosixPathruns we get.github//x.md. A short comment now spells this out so future readers don't think the collapse is dead code.pathparameter name — Renamepath→pso it no longer shadows thenode:pathimport in the same file.sameRelativePath— Switch the four positional strings to{dir, file}objects per the project's coding guidelines, and update both call sites (fromFile,forDeletion).Test plan
pnpm cicheck(fmt + oxlint + eslint + tsgo + vitest 5552 tests + cspell + secretlint) passes locally on Node 22.forDeletiontests:relativeDirPathis".github\\".".github\\instructions") stay non-root..github\\continues to pass — behavior is preserved, only the helper implementation changes.Refs #1603.