Skip to content

Bump dependencies and run tests in parallel#159

Merged
szmyd merged 4 commits into
eBay:mainfrom
sbinmalek:bump-dependencies-to-stable
May 26, 2026
Merged

Bump dependencies and run tests in parallel#159
szmyd merged 4 commits into
eBay:mainfrom
sbinmalek:bump-dependencies-to-stable

Conversation

@sbinmalek
Copy link
Copy Markdown
Contributor

Update homestore to ^7.5, sisl to ^13.2, and drop the @oss/master channel suffix from all conan requirements to track stable releases.

Set CTEST_PARALLEL_LEVEL from tools.build:jobs (default 3) so ctest runs all three test binaries concurrently during conan build.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates Conan dependencies (homestore and sisl) to newer compatible ranges, switches requirements to track stable releases (by removing the @oss/master channel suffix), and configures ctest to run test binaries in parallel during the Conan build.

Changes:

  • Bumped package version to 5.1.0 and updated dependency ranges (homestore ^7.5, sisl ^13.2), removing @oss/master.
  • Set CTEST_PARALLEL_LEVEL from tools.build:jobs (default 3) before invoking cmake.test().

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread conanfile.py Outdated
Comment on lines 101 to 103
jobs = self.conf.get("tools.build:jobs", default=3)
os.environ["CTEST_PARALLEL_LEVEL"] = str(jobs)
cmake.test()
Update homestore to ^7.5, sisl to ^13.2, and drop the @oss/master
channel suffix from all conan requirements to track stable releases.

Set CTEST_PARALLEL_LEVEL from tools.build:jobs (default 3) so ctest
runs all three test binaries concurrently during conan build.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

Comment thread conanfile.py Outdated
Comment on lines +102 to +103
jobs = self.conf.get("tools.build:jobs", default=3)
os.environ["CTEST_PARALLEL_LEVEL"] = str(jobs)
Comment thread conanfile.py Outdated
Comment on lines 102 to 104
jobs = self.conf.get("tools.build:jobs", default=3)
os.environ["CTEST_PARALLEL_LEVEL"] = str(jobs)
cmake.test()
sbinmalek and others added 3 commits May 26, 2026 13:38
Replace the global os.environ mutation with Conan's Environment helper,
scoping CTEST_PARALLEL_LEVEL to just the cmake.test() call so it does
not leak into subsequent recipe steps.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Switch all build_dependencies workflow references from rolling
master/main branches to pinned stable branches:
  - sisl:        master    → stable/v13.x
  - nuraft_mesg: main      → stable/v4.x
  - iomanager:   master    → stable/v12.x
  - homestore:   master    → stable/v7.x

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Update all ebay/sisl action refs from @master to @stable/v13.x,
nuraft_mesg checkout from main to stable/v4.x, and HomeStore
checkout from master to stable/v7.x.

Drop --user oss --channel flags from conan export commands to match
the channel-less requirements in conanfile.py.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@sbinmalek sbinmalek force-pushed the bump-dependencies-to-stable branch from ede0d9b to 37ff904 Compare May 26, 2026 20:51
@szmyd szmyd merged commit 6d88823 into eBay:main May 26, 2026
16 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants