legal: reject stale standalone artifact inspection - #54
Conversation
|
Warning Review limit reached
Next review available in: 31 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b912bc14d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "asset_url": ( | ||
| f"https://github.com/cli/cli/releases/download/v{gh_version}/" | ||
| f"gh_{gh_version}_linux_amd64.tar.gz" |
There was a problem hiding this comment.
Derive expected URLs from the build source
When a PR changes a download URL or asset-name template in images/base/Dockerfile or images/codex/Dockerfile while retaining the same version and bytes, the Build AMD64 gate still passes because these GitHub CLI, Codex, ttyd, and mise URLs are independently reconstructed here rather than checked against the URLs used by the Dockerfiles. The existing pin validator synchronizes Dockerfile versions and SHA-256 values but not these URL templates, so URL drift for four of the five required components remains undetected; make the build and inspection validator consume one URL source of truth or explicitly validate the Dockerfile download expressions.
Useful? React with 👍 / 👎.
Scope
Close the Codex P2 follow-up from #51 without restoring the temporary artifact-inspection workflow.
Changes
third_party/standalone-artifact-inspection.json;versions.env;mise.lockrecords;Build AMD64;Boundary
This is a mismatch gate only. It performs no network access and does not reintroduce a generic binary or dependency-license scanner.
Fixes the unresolved review thread on #51.
Refs #26 and #53.