fix: added the missing declarations #177#178
Merged
easingthemes merged 2 commits intoeasingthemes:mainfrom Feb 18, 2024
Merged
Conversation
skyArony
changed the title
skyArony
changed the title
easingthemes
requested changes
Feb 6, 2024
action.yml
Outdated
| SCRIPT_BEFORE_REQUIRED: | ||
| description: "If true, the action will fail if the before script fails" | ||
| required: false | ||
| default: "false" |
Owner
There was a problem hiding this comment.
Default should be false -> empty string, "".
Currently it's true -> string "false".
Ideally it should be boolean, but that would require more refactoring since only strings were expected until now.
Just changing to empty string should work fine.
action.yml
Outdated
| SCRIPT_AFTER_REQUIRED: | ||
| description: "If true, the action will fail if the after script fails" | ||
| required: false | ||
| default: "false" |
Owner
There was a problem hiding this comment.
Same as for SCRIPT_BEFORE_REQUIRED
Author
There was a problem hiding this comment.
Thank you for your reminder. I will correct it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commits added by the #141 work as expected, but there is a lack of relevant declarations in
action.yml, leading to:Invalid action input 'SCRIPT_BEFORE_REQUIRED'andInvalid action input 'SCRIPT_AFTER_REQUIRED'"Unexpected input(s) 'SCRIPT_BEFORE_REQUIRED', 'SCRIPT_AFTER_REQUIRED', valid inputs are ['SSH_PRIVATE_KEY', 'REMOTE_HOST', 'REMOTE_USER', 'REMOTE_PORT', 'SOURCE', 'TARGET', 'ARGS', 'SSH_CMD_ARGS', 'EXCLUDE', 'SCRIPT_BEFORE', 'SCRIPT_AFTER']".Therefore, I have added the relevant declarations in the PR to fix this issue #177