Migrate from setup.py to pyproject.toml#290
Merged
s-heppner merged 3 commits intoSep 13, 2024
Merged
Conversation
s-heppner
requested changes
Aug 30, 2024
Member
s-heppner
left a comment
s-heppner
left a comment
There was a problem hiding this comment.
Other than that small documentation thing, it LGTM now.
Thank you very much! :)
s-heppner
reviewed
Sep 13, 2024
Remove unnecessary comment
s-heppner
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we used
setup.pyfor specifying our package, together with arequirements.txtfor defining our dependencies.PEP 518 introduces
pyproject.tomlas the new and suggested way of specifying both, build process and dependencies.With this PR, we migrate from the old
setup.pyandrequirements.txtto usingpyproject.toml.