[WIP] build: Align with the upstream's upgrade to Webpack 5 by azatsarynnyy · Pull Request #1105 · eclipse-che/che-theia

azatsarynnyy · 2021-05-17T17:51:31Z

Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com

What does this PR do?

Upstream Theia has been upgraded to Webpack 5 in eclipse-theia/theia#9451
It requires updating the format of the provided arguments: --env arg instead of --env.arg
More details are here eclipse-che/che#19804 (comment)

Screenshot/screencast of this PR

What issues does this PR fix or reference?

eclipse-che/che#19804

How to test this PR?

Build should pass - no error from Webpack anymore.

PR Checklist

As the author of this Pull Request I made sure that:

Reviewers

Reviewers, please comment how you tested the PR when approving it.

Happy Path Channel

HAPPY_PATH_CHANNEL=stable

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

codecov · 2021-05-17T18:03:43Z

Codecov Report

Merging #1105 (f7f50e6) into master (eeb4526) will increase coverage by 2.85%.
The diff coverage is 54.11%.

❗ Current head f7f50e6 differs from pull request most recent head 6c4c55b. Consider uploading reports for the commit 6c4c55b to get more accurate results

@@            Coverage Diff             @@
##           master    #1105      +/-   ##
==========================================
+ Coverage   29.45%   32.30%   +2.85%     
==========================================
  Files         277      281       +4     
  Lines        9336     9564     +228     
  Branches     1380     1440      +60     
==========================================
+ Hits         2750     3090     +340     
+ Misses       6487     6378     -109     
+ Partials       99       96       -3

Impacted Files	Coverage Δ
...theia-about/src/browser/about-che-theia-dialog.tsx	`0.00% <ø> (ø)`
...ovisioner/src/node/git-configuration-controller.ts	`0.00% <0.00%> (ø)`
...eia-plugin-remote/src/node/hosted-plugin-remote.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-host-custom.ts	`0.00% <0.00%> (ø)`
...in-remote/src/node/plugin-remote-backend-module.ts	`0.00% <0.00%> (ø)`
...theia-plugin-remote/src/node/plugin-remote-init.ts	`0.00% <0.00%> (ø)`
...-che-theia-plugin-remote/src/node/plugin-remote.ts	`0.00% <0.00%> (ø)`
...ugin-remote/src/node/server-plugin-proxy-runner.ts	`0.00% <0.00%> (ø)`
...plugin-remote/src/node/terminal-container-aware.ts	`0.00% <0.00%> (ø)`
...a-plugin-remote/src/node/webviews-content-aware.ts	`0.00% <0.00%> (ø)`
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7fba8f...6c4c55b. Read the comment docs.

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy · 2021-05-20T18:35:48Z

build.include

 THEIA_GITHUB_REPO="eclipse-theia/theia"
 THEIA_VERSION="master"
 THEIA_BRANCH="master"
-THEIA_COMMIT_SHA="2eb4319fb459f30ad897e8467878154c6790aaef"


not the latest sha, as the latest commit brings another breaking changes
I'll look at it tomorrow

eclipse-che/che#19866

azatsarynnyy · 2021-05-20T19:08:18Z

Still WIP. Some problems with loading the static resources

Continue the investigation...

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy · 2021-05-26T15:08:17Z

[crw-ci-test --rebuild]

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

benoitf · 2021-05-31T13:24:13Z

@azatsarynnyy please update as well https://github.com/eclipse-che/che-theia/blob/upstream_aligh/generator/src/templates/assembly-package.mst#L71

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy · 2021-05-31T17:38:00Z

fighting with the next problem:

    'ERROR in Template execution failed: ReferenceError: process is not defined\n' +
    '\n' +
    'ERROR in ReferenceError: process is not defined\n' +
    '  \n' +
    '  - custom-html.html:2946 Object.489\n' +
    '    /home/theia-dev/theia-source-code/examples/assembly/cdn/custom-html.html:294    6:15\n' +

benoitf · 2021-06-01T12:21:52Z

you may try SimulatedGREG/electron-vue#871 (comment)

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

che-bot · 2021-06-07T22:17:29Z

❌ E2E Happy path tests failed ❗

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1105
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1105

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

azatsarynnyy · 2021-06-08T04:45:09Z

The build is fixed. Now investigating runtime problem

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

che-bot · 2021-06-10T17:19:32Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1105
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1105

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

benoitf · 2021-06-10T17:27:21Z

ready to merge ,?

che-bot · 2021-06-10T17:43:14Z

✅ E2E Happy path tests succeed 🎉

See Details

name	link
che-theia	quay.io/crw_pr/che-theia:1105
che-theia-endpoint-runtime-binary	quay.io/crw_pr/che-theia-endpoint-runtime-binary:1105

Test product:

tested with Eclipse Che on K8S (minikube v1.1.1)
E2E test scenario
E2E test pipeline source code

Use comment "[crw-ci-test]" to rerun happy path E2E test.
Use comment "[crw-ci-test --rebuild]" to re-build the images and rerun happy path E2E test.

Eclipse Che QE channel: https://mattermost.eclipse.org/eclipse/channels/eclipse-che-qe

azatsarynnyy · 2021-06-10T18:07:14Z

ready to merge ,?

Something went wrong with the PR status checks here, so I opened another one #1134
I want to check the build images and then will open it for a review. Today or tomorrow.

benoitf · 2021-06-10T18:27:51Z

Ok thx

azatsarynnyy · 2021-06-11T06:42:23Z

superseded by #1134

Align with upstream

a744aca

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Provide the args in Webpack 5 format

4b65407

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Provide the args in Webpack 5 format. Update tests

b12da35

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Pin to the upstream sha d734315e505ad4a7691a3f6f4a07d2209af0d9cf

1028a81

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

azatsarynnyy marked this pull request as ready for review May 20, 2021 18:34

azatsarynnyy requested review from RomanNikitenko, benoitf and vzhukovs as code owners May 20, 2021 18:34

azatsarynnyy commented May 20, 2021

View reviewed changes

azatsarynnyy changed the title ~~[WIP] Align with upstream~~ Align with the upstream's upgrade to Webpack 5 May 20, 2021

azatsarynnyy mentioned this pull request May 20, 2021

Adapt Che-Theia to upstream changes (Webpack) eclipse-che/che#19804

Closed

azatsarynnyy changed the title ~~Align with the upstream's upgrade to Webpack 5~~ [WIP] Align with the upstream's upgrade to Webpack 5 May 20, 2021

azatsarynnyy added 3 commits May 20, 2021 22:39

Export a function from the Webpack config to read the passed environment

dc2618d

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Export a function from the Webpack config to read the passed environment

e45f32f

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Export a function from the Webpack config to read the passed environment

960033b

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Export a function from the Webpack config to read the passed environment

49e3c4d

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

azatsarynnyy marked this pull request as draft May 21, 2021 07:14

Add 'mime' lib explicitly to solve 'mime.getType is not a function'

fa6d73b

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Update 'defaultVendors' prop. according to the migration guide

d00ad41

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Update 'defaultVendors' prop. according to the migration guide

0957837

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

azatsarynnyy added 2 commits May 31, 2021 16:53

Upgrade html-webpack-plugin

73c7790

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Upgrade html-webpack-plugin

99b1bee

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

One more workaround (but doesn't work)

f7f50e6

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

This comment has been minimized.

Sign in to view

Fix 'process is not defined' error

33e5e7e

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy added 2 commits June 10, 2021 17:46

htmlWebpackPlugin.files.chunks are stored in htmlWebpackPlugin.files.js

5040718

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

Fix the chunks loading

6c4c55b

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>

azatsarynnyy closed this Jun 11, 2021

azatsarynnyy deleted the upstream_aligh branch June 11, 2021 06:48

Conversation

azatsarynnyy commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does this PR do?

Screenshot/screencast of this PR

What issues does this PR fix or reference?

How to test this PR?

PR Checklist

Reviewers

Happy Path Channel

Uh oh!

codecov bot commented May 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azatsarynnyy May 20, 2021

Choose a reason for hiding this comment

Uh oh!

azatsarynnyy May 26, 2021

Choose a reason for hiding this comment

Uh oh!

azatsarynnyy commented May 20, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

azatsarynnyy commented May 26, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

benoitf commented May 31, 2021

Uh oh!

This comment has been minimized.

This comment has been minimized.

azatsarynnyy commented May 31, 2021

Uh oh!

benoitf commented Jun 1, 2021

Uh oh!

This comment has been minimized.

che-bot commented Jun 7, 2021

Uh oh!

azatsarynnyy commented Jun 8, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

che-bot commented Jun 10, 2021

Uh oh!

benoitf commented Jun 10, 2021

Uh oh!

che-bot commented Jun 10, 2021

Uh oh!

azatsarynnyy commented Jun 10, 2021

Uh oh!

benoitf commented Jun 10, 2021

Uh oh!

azatsarynnyy commented Jun 11, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

azatsarynnyy commented May 17, 2021 •

edited

Loading

codecov bot commented May 17, 2021 •

edited

Loading

azatsarynnyy commented Jun 8, 2021 •

edited

Loading