This repository was archived by the owner on Apr 4, 2023. It is now read-only.
Pin Che Theia to upstream Theia before the file watchers related changes as it breaks Che#886
Merged
azatsarynnyy merged 2 commits intomasterfrom Oct 21, 2020
Merged
Pin Che Theia to upstream Theia before the file watchers related changes as it breaks Che#886azatsarynnyy merged 2 commits intomasterfrom
azatsarynnyy merged 2 commits intomasterfrom
Conversation
…ges as it breaks Che Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
Contributor
|
❌ E2E Happy path tests failed ❗
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
Signed-off-by: Roman Nikitenko <rnikiten@redhat.com>
Contributor
|
✅ E2E Happy path tests succeed 🎉
See Details
Tested with Eclipse Che Single User on K8S (minikube v1.1.1) ℹ️ |
benoitf
approved these changes
Oct 21, 2020
22 tasks
|
This PR title scared me. The watcher changes are not the cause right? |
Contributor
|
@marechal-p no :-) |
Contributor
|
it was activation plug-in changes |
Member
Author
sorry to scare you @marechal-p 😄 |
vinokurig
pushed a commit
that referenced
this pull request
Apr 6, 2021
… don't get sources twice; add missing --use-tmp-dir flag (#886) Change-Id: I54a6a569ca964734296fd60b4db4c96fb080bc8c Signed-off-by: nickboldt <nboldt@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Zatsarynnyi azatsary@redhat.com
What does this PR do?
Pins Che Theia to upstream Theia before the file watchers related changes (eclipse-theia/theia#8546) as it breaks Che.
See eclipse-che/che#18151 for the details.
What issues does this PR fix or reference?
Release Notes
Docs PR
Happy Path Channel
HAPPY_PATH_CHANNEL=stable