Skip to content

Bug 493634: better error handling on setup/teardownEngine() #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jonahgraham wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bug 493634: better error handling on setup/teardownEngine() #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions ....eclipse.ease.lang.ruby.jruby/src/org/eclipse/ease/lang/ruby/jruby/JRubyScriptEngine.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@

import org.eclipse.ease.AbstractScriptEngine;
import org.eclipse.ease.Script;
import org.eclipse.ease.ScriptEngineException;
import org.eclipse.ease.lang.ruby.RubyHelper;
import org.jruby.embed.LocalVariableBehavior;
import org.jruby.embed.ScriptingContainer;
Expand All @@ -38,19 +39,16 @@ public void terminateCurrent() {
}

@Override
protected boolean setupEngine() {
protected void setupEngine() throws ScriptEngineException {
fEngine = new ScriptingContainer(LocalVariableBehavior.PERSISTENT);

fEngine.setOutput(getOutputStream());
fEngine.setError(getErrorStream());
fEngine.setInput(getInputStream());

return true;
}

@Override
protected boolean teardownEngine() {
return true;
protected void teardownEngine() throws ScriptEngineException {
}

@Override
Expand Down