Skip to content

Removed flyway downgrade #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bogdan-bondar merged 1 commit into from
May 21, 2021
Merged

Removed flyway downgrade #1114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,9 +145,7 @@
<rabbitmq.http-client.version>3.5.0.RELEASE</rabbitmq.http-client.version>
<!-- Newer version contains new rule that we violate. Needs to be fixed first -->
<hibernate-validator.version>6.0.20.Final</hibernate-validator.version>
<!-- Newer community version does not support MySQL 5.6 anymore -->
<flyway.version>5.2.4</flyway.version>
Copy link
Copy Markdown
Contributor

@a-sayyed a-sayyed May 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and we don't need to track this anymore? or would we end up with the same situation with future versions?

Copy link
Copy Markdown
Contributor Author

@ramannas ramannas May 4, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, since we agreed to support MySQL 5.7 pinning flyway version is not anymore required and can rely on spring specific version.
would we end up with the same situation with future versions -incase Flyway decides to remove support for 5.7 in their future versions then YES... we might have to do something similar like this until we move to their supported version :)

<!-- Spring boot version overrides - END -->
<!-- Spring boot version overrides - END -->

<!-- Vaadin versions - START -->
<vaadin.version>8.12.3</vaadin.version>
Expand Down