Prevent rebuild triggered by type hierarchy restoration #2385
+44
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedejeanne
reviewed
Aug 18, 2025
Contributor
fedejeanne
left a comment
fedejeanne
left a comment
There was a problem hiding this comment.
Thank you for the PR @steffenschmitt1 !
Questions:
- How do I test it and what is the expected outcome?
- This one fixes #2305, right? In that case, I would add
Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/2305to the description of this PR and modify the commit-text:
Prevent rebuild triggered by type hierarchy restoration #2305
Fixes https://github.com/eclipse-jdt/eclipse.jdt.ui/issues/2305
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Outdated
Show resolved
Hide resolved
org.eclipse.jdt.ui/ui/org/eclipse/jdt/internal/ui/typehierarchy/TypeHierarchyViewPart.java
Outdated
Show resolved
Hide resolved
steffenschmitt1
force-pushed
the
master
branch
from
5541cbb to
a960b79
Compare
Author
|
Reproducing the rebuild:
Accordingly, the bugfix can be verified by confirming that no rebuild is triggered. |
steffenschmitt1
force-pushed
the
master
branch
from
a960b79 to
c5b40a1
Compare
Contributor
|
Hm, odd. After rebasing on |
steffenschmitt1
force-pushed
the
master
branch
2 times, most recently
from
5beaecb to
b350c33
Compare
Contributor
My bad, @steffenschmitt1, you didn't rebase on |
steffenschmitt1
force-pushed
the
master
branch
from
b350c33 to
0ae8435
Compare
steffenschmitt1
force-pushed
the
master
branch
from
0ae8435 to
145b9a4
Compare
Author
|
I won’t be able to take care of this any further. I believe the PR is basically fine as it is, unless something has changed in the meantime. If anything else is needed, someone else will have to take over. @fedejeanne @HeikoKlare |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent rebuild triggered by type hierarchy restoration.
Fixes #2305