Conversation
pisv
left a comment
pisv
left a comment
There was a problem hiding this comment.
LGTM, apart from Either.java having some unused imports left after removing the deprecated methods there.
Long deprecated and replaced with the more generic JsonRpcData Fixes eclipse-lsp4j#876
jonahgraham
force-pushed
the
Remove-deprecated-API
branch
from
d943a8d to
de1ad7f
Compare
Instead use TypeUtils helper methods Fixes eclipse-lsp4j#877
jonahgraham
force-pushed
the
Remove-deprecated-API
branch
from
de1ad7f to
12d5475
Compare
|
The push of commit de1ad7f was simply rebasing. The push of commit 12d5475 resolved "apart from Either.java having some unused imports left after removing the deprecated methods there." from #881 (review) |
These were the old way of accessing factories. Fixes eclipse-lsp4j#878
This was a misspelling and is replaced by ServerNotInitialized Fixes eclipse-lsp4j#879
Mitigation: either upgrade to Jakarta version or remain on older version of LSP4J. Fixes eclipse-lsp4j#647
jonahgraham
force-pushed
the
Remove-deprecated-API
branch
from
12d5475 to
8b5ed81
Compare
|
@pisv I think this is ready to review + merge, there are no |
pisv
left a comment
pisv
left a comment
There was a problem hiding this comment.
LGTM, thanks for cleaning it all up! 👍
Nothing to suggest, except of adding a bunch of pesky <p> tags in JavaDoc comments.
Also, it is very nice to see only one warning left in the LSP4J workspace:
The import java.util.Objects is never used DSPLauncherTest.java /org.eclipse.lsp4j.debug/src/test/java/org/eclipse/lsp4j/debug/test line 21
(I don't think this warning is related to this PR, although it would be nice to fix it.)
org.eclipse.lsp4j.debug/src/main/java/org/eclipse/lsp4j/debug/DebugProtocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j.debug/src/main/java/org/eclipse/lsp4j/debug/DebugProtocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j.jsonrpc/src/main/java/org/eclipse/lsp4j/jsonrpc/ProtocolDeprecated.java
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
org.eclipse.lsp4j/src/main/java/org/eclipse/lsp4j/Protocol.xtend
Outdated
Show resolved
Hide resolved
The LSP4J project does not use standard Deprecated annotation when implementing LSP/DAP specification as it leads to unresolvable deprecation warnings. The standard Deprecated annotation should be used in LSP4J for LSP4J's own API that is not directly implementing the protocol specification. This commit introduces `@ProtocolDeprecated` as an annotation to make it easier for API consumers to identify areas that the underlying LSP/DAP have deprecated. Fixes eclipse-lsp4j#895
use ConcurrentMessageProcessor.beginProcessing instead Fixes eclipse-lsp4j#922
jonahgraham
force-pushed
the
Remove-deprecated-API
branch
from
54796a6 to
4b3241d
Compare
Applied
I have a few hundred warnings still in LSP4J, including that one - lets continue convo here: #923 - in particular, I assume your dev environment is different than mine. |
When the websocket bundle was removed in eclipse-lsp4j#881 the about.html in the resources directory was left in the git repo. This commit removes it.
When the websocket bundle was removed in #881 the about.html in the resources directory was left in the git repo. This commit removes it.
2 participants
Fixes #874
Individual commits fix the sub-issues of #874