fix(jsonrpc): correct newline state machine in StreamMessageProducer#904
Merged
pisv merged 1 commit intoeclipse-lsp4j:mainfrom Nov 8, 2025
Merged
Conversation
The listener sets `newLine = false` after parsing a blank line (end-of-headers) and then **unconditionally** sets it back to `true`, leaving the state inconsistent. This caused a lone trailing CRLF between messages to be misinterpreted as an additional blank line, triggering a "Missing header Content-Length" error via `fireError`. This fix prevents spurious errors and ensures robust parsing across message boundaries.
pisv
approved these changes
Nov 8, 2025
Contributor
pisv
left a comment
pisv
left a comment
There was a problem hiding this comment.
Good catch! Thank you for the fix 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The listener sets
newLine = falseafter parsing a blank line (end-of-headers) and then unconditionally sets it back totrue, leaving the state inconsistent. This caused a lone trailing CRLF between messages to be misinterpreted as an additional blank line, triggering a "Missing header Content-Length" error viafireError.This fix prevents spurious errors and ensures robust parsing across message boundaries.