Skip to content

Replace method toProxy() with toServiceObject()#913

Merged
pisv merged 1 commit intoeclipse-lsp4j:mainfrom
snowdrop:issue-012-wrong-method
Nov 7, 2025
Merged

Replace method toProxy() with toServiceObject()#913
pisv merged 1 commit intoeclipse-lsp4j:mainfrom
snowdrop:issue-012-wrong-method

Conversation

@cmoulliard
Copy link

@cmoulliard cmoulliard force-pushed the issue-012-wrong-method branch from e04a787 to 0297dd1 Compare November 4, 2025 13:29
@pisv
Copy link
Contributor

pisv commented Nov 4, 2025

@cmoulliard Thank you for catching the issue and fixing it, much appreciated! 👍

I noticed that the commit was signed-off with a different email address (domain) than the commit author's. It is fine to remove the sign-off completely if you like, it is no longer required by the Eclipse Foundation.

@pisv
Copy link
Contributor

pisv commented Nov 6, 2025

@cmoulliard Can you please update the email address in your commit sign-off to match the email address you authored the commit with, or just remove the sign-off, as mentioned in my previous comment? I'll then be able to happily approve and merge this PR. Thanks!

@cmoulliard cmoulliard force-pushed the issue-012-wrong-method branch from 0297dd1 to f25ce5a Compare November 7, 2025 11:18
@cmoulliard
Copy link
Author

Can you please update the email address in your commit sign-off to match the email address you authored the commit with, or just remove the sign-off, as mentioned in my previous comment? I'll then be able to happily approve and merge this PR. Thanks!

I removed the signature

Copy link
Contributor

@pisv pisv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you! 👍

@pisv pisv merged commit 33a6e15 into eclipse-lsp4j:main Nov 7, 2025
1 check passed
@pisv pisv added this to the 1.0.0 milestone Nov 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix wrong method name documented within jsonrpc.md

2 participants