Remove throws IOException from methods that do not need to throw it#938
Merged
pisv merged 1 commit intoeclipse-lsp4j:mainfrom Dec 9, 2025
Merged
Remove throws IOException from methods that do not need to throw it#938pisv merged 1 commit intoeclipse-lsp4j:mainfrom
throws IOException from methods that do not need to throw it#938pisv merged 1 commit intoeclipse-lsp4j:mainfrom
Conversation
Closes eclipse-lsp4j#934. Also removes `@SuppressWarnings("resource")` on `StreamMessageConsumerBenchmark.setup`, which is no longer necessary and caused `At least one of the problems in category 'resource' is not analysed due to a compiler option being ignored` info.
jonahgraham
approved these changes
Dec 9, 2025
Contributor
jonahgraham
left a comment
jonahgraham
left a comment
There was a problem hiding this comment.
Thanks @pisv for picking this up and getting us to 0 warnings.
Contributor
|
Feel free to merge @pisv if you are ready. |
Contributor
Author
|
@jonahgraham Thank you for your review and the bulk of the work in getting us to 0 warnings 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #934.
Also removes
@SuppressWarnings("resource")onStreamMessageConsumerBenchmark.setup, which is no longer necessary and causedAt least one of the problems in category 'resource' is not analysed due to a compiler option being ignoredinfo.This PR should fix all remaining problems (warnings/infos) in LSP4J workspace.