Migrate StackRendererTest and others to JUnit 5 #3636

vogella · 2026-01-04T20:41:43Z

This PR migrates the following tests to JUnit 5:

StackRendererTest
ToolBarManagerRendererTest
MPartTest
MWindowTest
PartOnTopManagerTest
MenuManagerRendererTest
PartRenderingEngineTests

Key changes:

Replaced WorkbenchContextRule with WorkbenchContextExtension
Updated imports to org.junit.jupiter.api.*
Updated annotations (@before -> @beforeeach, etc.)
Swapped assertion arguments where necessary
Updated assumptions
Added org.opentest4j dependency for assumptions

Verified with Maven Tycho.

github-actions · 2026-01-04T20:49:51Z

Test Results

3 015 files ±0 3 015 suites ±0 2h 12m 16s ⏱️ + 5m 33s
8 258 tests ±0 8 010 ✅ ±0 248 💤 ±0 0 ❌ ±0
23 598 runs ±0 22 807 ✅ ±0 791 💤 ±0 0 ❌ ±0

Results for commit 010bfd3. ± Comparison against base commit 7445acd.

♻️ This comment has been updated with latest results.

eclipse-platform-bot · 2026-01-04T20:53:24Z

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.core.filebuffers/META-INF/MANIFEST.MF
bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
bundles/org.eclipse.search.core/META-INF/MANIFEST.MF
bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
bundles/org.eclipse.text/META-INF/MANIFEST.MF
tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF
tests/org.eclipse.text.tests/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From e1b4f9a8ef72897fe07d77d21c5f38b1a35ae830 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sun, 4 Jan 2026 20:53:07 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/bundles/org.eclipse.core.filebuffers/META-INF/MANIFEST.MF b/bundles/org.eclipse.core.filebuffers/META-INF/MANIFEST.MF
index 0881682186..28637f565f 100644
--- a/bundles/org.eclipse.core.filebuffers/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.core.filebuffers/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.core.filebuffers; singleton:=true
-Bundle-Version: 3.8.500.qualifier
+Bundle-Version: 3.8.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: 
diff --git a/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
index 6a786675cf..2c64997ff1 100644
--- a/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.emf.xpath/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.e4.emf.xpath;deprecated:="This bundle is deprecated since 2025-03 (removal in 2027-03 or later)"
-Bundle-Version: 0.6.100.qualifier
+Bundle-Version: 0.6.200.qualifier
 Bundle-RequiredExecutionEnvironment: JavaSE-17
 Require-Bundle: org.eclipse.emf.ecore;bundle-version="2.35.0",
  org.eclipse.core.runtime;bundle-version="3.29.0",
diff --git a/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF b/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
index a4fdac38f2..9f0f659919 100644
--- a/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ltk.core.refactoring/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.core.refactoring
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.core.refactoring; singleton:=true
-Bundle-Version: 3.15.100.qualifier
+Bundle-Version: 3.15.200.qualifier
 Bundle-Activator: org.eclipse.ltk.internal.core.refactoring.RefactoringCorePlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.search.core/META-INF/MANIFEST.MF b/bundles/org.eclipse.search.core/META-INF/MANIFEST.MF
index e7d708a0ed..2df289b6e5 100644
--- a/bundles/org.eclipse.search.core/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.search.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.search.core;singleton:=true
-Bundle-Version: 3.16.600.qualifier
+Bundle-Version: 3.16.700.qualifier
 Bundle-Activator: org.eclipse.search.internal.core.SearchCorePlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF b/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
index a45f16b13a..43dd271953 100644
--- a/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.text.quicksearch/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.text.quicksearch;singleton:=true
-Bundle-Version: 1.3.300.qualifier
+Bundle-Version: 1.3.400.qualifier
 Bundle-Activator: org.eclipse.text.quicksearch.internal.ui.QuickSearchActivator
 Require-Bundle: org.eclipse.ui;bundle-version="[3.113.0,4.0.0)",
  org.eclipse.core.resources;bundle-version="[3.13.0,4.0.0)",
diff --git a/bundles/org.eclipse.text/META-INF/MANIFEST.MF b/bundles/org.eclipse.text/META-INF/MANIFEST.MF
index a247d39b79..516af6ca8a 100644
--- a/bundles/org.eclipse.text/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.text/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.text
-Bundle-Version: 3.14.500.qualifier
+Bundle-Version: 3.14.600.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: 
diff --git a/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
index 9a150f31e8..a8e11d3bdc 100644
--- a/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.core.filebuffers.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.core.filebuffers.tests;singleton:=true
-Bundle-Version: 3.13.600.qualifier
+Bundle-Version: 3.13.700.qualifier
 Bundle-Activator: org.eclipse.core.filebuffers.tests.FileBuffersTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %Plugin.providerName
diff --git a/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
index 84e9f71799..62fe594fdf 100644
--- a/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ltk.core.refactoring.tests/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Automatic-Module-Name: org.eclipse.ltk.core.refactoring.tests
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ltk.core.refactoring.tests; singleton:=true
-Bundle-Version: 3.10.700.qualifier
+Bundle-Version: 3.10.800.qualifier
 Bundle-Activator: org.eclipse.ltk.core.refactoring.tests.RefactoringCoreTestPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
diff --git a/tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF
index 0a788b4950..7c8d106877 100644
--- a/tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.text.quicksearch.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.text.quicksearch.tests
-Bundle-Version: 1.3.100.qualifier
+Bundle-Version: 1.3.200.qualifier
 Require-Bundle: org.eclipse.core.runtime,
  org.eclipse.text.quicksearch;bundle-version="1.0.300",
  org.eclipse.core.resources,
diff --git a/tests/org.eclipse.text.tests/META-INF/MANIFEST.MF b/tests/org.eclipse.text.tests/META-INF/MANIFEST.MF
index 5491c055d2..0510c00c72 100644
--- a/tests/org.eclipse.text.tests/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.text.tests/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Plugin.name
 Bundle-SymbolicName: org.eclipse.text.tests
-Bundle-Version: 3.14.1000.qualifier
+Bundle-Version: 3.14.1100.qualifier
 Bundle-Vendor: %Plugin.providerName
 Bundle-Localization: plugin
 Export-Package: 
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

vogella · 2026-01-05T11:13:54Z

[org.eclipse.m2e.core.prefs] musst be removed

Migrate the following tests to JUnit 5: - StackRendererTest - ToolBarManagerRendererTest - MPartTest - MWindowTest - PartOnTopManagerTest - MenuManagerRendererTest - PartRenderingEngineTests This involves: - Replacing WorkbenchContextRule with WorkbenchContextExtension - Updating imports to org.junit.jupiter.api.* - Updating annotations (@before -> @beforeeach, etc.) - Swapping assertion arguments where necessary - Updating assumptions - Adding org.opentest4j dependency for assumptions

vogella force-pushed the context-rule branch 2 times, most recently from 61abaaa to b20e8b8 Compare January 5, 2026 10:06

vogella force-pushed the context-rule branch from b20e8b8 to 7c3839c Compare January 5, 2026 11:23

vogella force-pushed the context-rule branch from 7c3839c to 010bfd3 Compare January 5, 2026 11:24

akurtakov merged commit ed45ed2 into eclipse-platform:master Jan 5, 2026
18 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Migrate StackRendererTest and others to JUnit 5 #3636

Migrate StackRendererTest and others to JUnit 5 #3636

vogella commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026 •

edited

Loading

Uh oh!

eclipse-platform-bot commented Jan 4, 2026

Uh oh!

vogella commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Migrate StackRendererTest and others to JUnit 5 #3636

Migrate StackRendererTest and others to JUnit 5 #3636

Conversation

vogella commented Jan 4, 2026

Uh oh!

github-actions bot commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

eclipse-platform-bot commented Jan 4, 2026

Uh oh!

vogella commented Jan 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions bot commented Jan 4, 2026 •

edited

Loading