Skip to content

Reorganize folder structure#211

Open
MaciejKaszynski wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:reorganize-folder-structure
Open

Reorganize folder structure#211
MaciejKaszynski wants to merge 2 commits into
eclipse-score:mainfrom
etas-contrib:reorganize-folder-structure

Conversation

@MaciejKaszynski
Copy link
Copy Markdown
Contributor

@MaciejKaszynski MaciejKaszynski commented May 22, 2026

Reorganize folder structure to follow other score modules and the description in #210

Resolves:

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 22, 2026

License Check Results

🚀 The license check job ran with the Bazel command:

bazel run --lockfile_mode=error //:license-check

Status: ⚠️ Needs Review

Click to expand output
[License Check Output]
Extracting Bazel installation...
Starting local Bazel server (8.4.2) and connecting to it...
INFO: Invocation ID: 21def262-afc9-4105-8949-4479f0524dda
Computing main repo mapping: 
Computing main repo mapping: 
Loading: 
Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Loading: 0 packages loaded
    currently loading: 
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)
Analyzing: target //:license-check (1 packages loaded, 0 targets configured)

Analyzing: target //:license-check (31 packages loaded, 10 targets configured)

Analyzing: target //:license-check (85 packages loaded, 10 targets configured)

Analyzing: target //:license-check (132 packages loaded, 996 targets configured)

Analyzing: target //:license-check (145 packages loaded, 4351 targets configured)

Analyzing: target //:license-check (150 packages loaded, 8043 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

Analyzing: target //:license-check (157 packages loaded, 8094 targets configured)

INFO: Analyzed target //:license-check (162 packages loaded, 10232 targets configured).
[5 / 14] [Prepa] Expanding template external/score_tooling+/dash/tool/formatters/_dash_format_converter_stage2_bootstrap.py [for tool]
[14 / 16] [Prepa] JavaToolchainCompileBootClasspath external/rules_java+/toolchains/platformclasspath.jar
[15 / 16] Building license.check.license_check.jar (); 0s disk-cache, multiplex-worker
INFO: Found 1 target...
Target //:license.check.license_check up-to-date:
  bazel-bin/license.check.license_check
  bazel-bin/license.check.license_check.jar
INFO: Elapsed time: 20.891s, Critical Path: 2.69s
INFO: 16 processes: 12 internal, 3 processwrapper-sandbox, 1 worker.
INFO: Build completed successfully, 16 total actions
INFO: Running command line: bazel-bin/license.check.license_check ./formatted.txt <args omitted>
usage: org.eclipse.dash.licenses.cli.Main [-batch <int>] [-cd <url>]
       [-confidence <int>] [-ef <url>] [-excludeSources <sources>] [-help] [-lic
       <url>] [-project <shortname>] [-repo <url>] [-review] [-summary <file>]
       [-timeout <seconds>] [-token <token>]

Comment thread score/mw/launch_manager_daemon/health_monitor_lib/BUILD Outdated
Comment thread score/mw/health/health_monitoring_lib/cpp/common.cpp
Comment thread score/mw/launch_manager/common/concurrency/BUILD
Comment thread score/mw/launch_manager/alive_monitor/Monitor.h
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we move everything under health_monitor_lib/src/score/lcm/saf to be in score/mw/launch_manager_daemon/alive_monitor?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (Force pushed on a6ccb53)

Comment thread score/mw/launch_manager/lifecycle_client_lib/BUILD Outdated
Comment thread score/mw/common/BUILD Outdated
Comment thread score/mw/launch_manager/control/BUILD
Comment thread score/mw/launch_manager/configuration/BUILD
@@ -1,5 +1,5 @@
# *******************************************************************************
# Copyright (c) 2026 Contributors to the Eclipse Foundation
# Copyright (c) 2025 Contributors to the Eclipse Foundation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why reverting copyright to previous year?

Copy link
Copy Markdown
Contributor Author

@MaciejKaszynski MaciejKaszynski May 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed (Force pushed on a6ccb53)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might be missing a context, but why is helgrind_annotations placed in details/ and not just in concurrency/ or concurrency/helgrind/?

@@ -0,0 +1,114 @@
/********************************************************************************
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider moving new ThreadPool to a separate PR.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted on c9a6f4b

Comment thread score/mw/common/BUILD Outdated
@@ -12,8 +12,8 @@
********************************************************************************/
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving to other PR, seems new.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually just config.hpp and was renamed as there was a different config bazel target, and calling this config.hpp doesn't make sense.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding include prefixes to submodules instead of having nested directories in include dirs.
E.g., score/mw/health/health_monitoring_lib/cpp/include/score/hm/deadline/deadline_monitor.h -> score/mw/health/health_monitoring_lib/cpp/include/deadline/deadline_monitor.h with score/hm added to module as include prefix.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some more changes in health_monitoring_lib. Now the include will be score/mw/health/health_monitoring_lib/deadline/deadline_monitor.h

Comment thread score/mw/lifecycle/lifecycle_client/application.cpp Outdated
Moving all files to comply with other modules
@MaciejKaszynski MaciejKaszynski force-pushed the reorganize-folder-structure branch from b14c440 to c9a6f4b Compare May 25, 2026 16:01
@MaciejKaszynski MaciejKaszynski marked this pull request as ready for review May 25, 2026 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants