Reorganize folder structure#211
Conversation
License Check Results🚀 The license check job ran with the Bazel command: bazel run --lockfile_mode=error //:license-checkStatus: Click to expand output |
There was a problem hiding this comment.
Can we move everything under health_monitor_lib/src/score/lcm/saf to be in score/mw/launch_manager_daemon/alive_monitor?
9f6965d to
6fee38e
Compare
| @@ -1,5 +1,5 @@ | |||
| # ******************************************************************************* | |||
| # Copyright (c) 2026 Contributors to the Eclipse Foundation | |||
| # Copyright (c) 2025 Contributors to the Eclipse Foundation | |||
There was a problem hiding this comment.
Why reverting copyright to previous year?
There was a problem hiding this comment.
I might be missing a context, but why is helgrind_annotations placed in details/ and not just in concurrency/ or concurrency/helgrind/?
| @@ -0,0 +1,114 @@ | |||
| /******************************************************************************** | |||
There was a problem hiding this comment.
Please consider moving new ThreadPool to a separate PR.
| @@ -12,8 +12,8 @@ | |||
| ********************************************************************************/ | |||
There was a problem hiding this comment.
Consider moving to other PR, seems new.
There was a problem hiding this comment.
This is actually just config.hpp and was renamed as there was a different config bazel target, and calling this config.hpp doesn't make sense.
There was a problem hiding this comment.
Consider adding include prefixes to submodules instead of having nested directories in include dirs.
E.g., score/mw/health/health_monitoring_lib/cpp/include/score/hm/deadline/deadline_monitor.h -> score/mw/health/health_monitoring_lib/cpp/include/deadline/deadline_monitor.h with score/hm added to module as include prefix.
There was a problem hiding this comment.
I did some more changes in health_monitoring_lib. Now the include will be score/mw/health/health_monitoring_lib/deadline/deadline_monitor.h
e54ad54 to
bc818f4
Compare
Moving all files to comply with other modules
bc818f4 to
b14c440
Compare
b14c440 to
c9a6f4b
Compare
Reorganize folder structure to follow other score modules and the description in #210
Resolves: