Conversation
Webhook is called, whenever a CR is requested in a specific version. This is enabled from these versions: - `AppDefintion.v1beta8` - `Session.v1beta6` - `Workspace.v1beta3` Older versions are deprecated and no longer in the definition. Move status like fields to status: - `Session.v1beta7`: Move `url`, `lastActivity` and `error` fields from the spec to the status. - `Workspace.v1beta4`: Move the `error` field from the spec to the status. Also add the `error` field to `Workspace.v1beta3` as it was missing Remove `timeout.strategy` from AppDefinition - `AppDefinition.v1beta9`: Removed `timeout.strategy` and `timeout.limit` is now just `timeout`. This was done, as there is only one Strategy left. Contributed on behalf of STMicroelectronics Co-authored-by: Johannes Faltermeier <jfaltermeier@eclipsesource.com>
Contributor
jfaltermeier
left a comment
jfaltermeier
left a comment
There was a problem hiding this comment.
I had a first look without testing.
I've only noticed one small issue
| dnsNames: | ||
| - "conversion-webhook-service.{{ .Release.Namespace }}.svc" | ||
| issuerRef: | ||
| name: theia-cloud-selfsigned-issuer |
Contributor
There was a problem hiding this comment.
I think it's possible to change the name of the selfsigned issuer in the base chart with issuerstaging.name. So this might not work in all cases
Contributor
Author
There was a problem hiding this comment.
Ah yes good catch. I will make this configurable via the values.
Contributor
Author
There was a problem hiding this comment.
I also removed two unsued values from the main chart in the commit below.
Also remove unused values from main chart Contributed on behalf of STMicroelectronics
jfaltermeier
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Webhook is called, whenever a CR is requested in a specific version. This is enabled from these versions:
AppDefintion.v1beta8Session.v1beta6Workspace.v1beta3Older versions are deprecated and no longer in the definition.Move status like fields to status:
Session.v1beta7: Moveurl,lastActivityanderrorfields from the spec to the status.Workspace.v1beta4: Move theerrorfield from the spec to the status. Also add theerrorfield toWorkspace.v1beta3as it was missingRemove
timeout.strategyfrom AppDefinitionAppDefinition.v1beta9: Removedtimeout.strategyandtimeout.limitis now justtimeout. This was done, as there is only one Strategy left.Contributed on behalf of STMicroelectronics
Co-authored-by: Johannes Faltermeier jfaltermeier@eclipsesource.com
Main Repo PR: