Conversation
Also group together demo application relevant values in demoApplication: - `image` -> `demoApplication` - `monitor.port` -> `demoApplication.monitor.port` - `monitor.activityTracker.timeoutAfter` -> `demoApplication.monitor.activityTracker.timeoutAfter` - `monitor.activityTracker.notifyAfter` -> `demoApplication.monitor.activityTracker.notifyAfter` Provide shortnames for AppDefinition (appdef, ad) and Workspaces (ws) Contributed on behalf of STMicroelectronics
jfaltermeier
approved these changes
Mar 26, 2024
Contributor
jfaltermeier
left a comment
jfaltermeier
left a comment
There was a problem hiding this comment.
LGTM!
I think the existing documentation for the monitor port was missing the vscode extension. Once we have this in as well, we may merge this.
Contributed on behalf of STMicroelectronics
sgraband
referenced
this pull request
in eclipse-theia/theia-cloud
Mar 26, 2024
Adjust to new helm chart changes added with https://github.com/eclipsesource/theia-cloud-helm/pull/52. Move values file into `terraform/values`. Remove outdated `helm` directory. Contributed on behalf of STMicroelectronics
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also group together demo application relevant values in demoApplication:
image->demoApplicationmonitor.port->demoApplication.monitor.portmonitor.activityTracker.timeoutAfter->demoApplication.monitor.activityTracker.timeoutAftermonitor.activityTracker.notifyAfter->demoApplication.monitor.activityTracker.notifyAfterProvide shortnames for AppDefinition (appdef, ad) and Workspaces (ws)
Main-Repo PR: https://github.com/eclipsesource/theia-cloud/pull/289
Contributed on behalf of STMicroelectronics