Add WebView Support eclipsesource/theia-cloud#296#57
Merged
jfaltermeier merged 2 commits intomainfrom Jun 17, 2024
Merged
Conversation
jfaltermeier
changed the title
jfaltermeier
force-pushed
the
jf/webviews
branch
from
f477c60 to
b7a4e36
Compare
jfaltermeier
force-pushed
the
jf/webviews
branch
2 times, most recently
from
53a62d6 to
449169b
Compare
jfaltermeier
force-pushed
the
jf/webviews
branch
5 times, most recently
from
ff658af to
b9a011f
Compare
jfaltermeier
force-pushed
the
jf/webviews
branch
from
b9a011f to
03572aa
Compare
* add additional information to AppDefinition for other hostnames that have to be exposed * adapt self-signed certificate generation to use a CA that can be imported as an authority in a browser * add additional wildcard rules when installing the instance ingress * adapt document regeneration documentation to always use latest image * optionally set tls secret name when using paths
jfaltermeier
force-pushed
the
jf/webviews
branch
from
03572aa to
9001b69
Compare
sgraband
reviewed
Jun 12, 2024
Contributor
sgraband
left a comment
sgraband
left a comment
There was a problem hiding this comment.
I tested it and it works great 🎉 I have some comments regarding the functionality/naming of one of the fields. Could you take a look at those?
* rename additionalWildcardInstances to allWildcardInstances
sgraband
approved these changes
Jun 17, 2024
Contributor
sgraband
left a comment
sgraband
left a comment
There was a problem hiding this comment.
Thanks for the changes and clarifications. Looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
hosts.paths.tlsSecretNameboolean property which defaults tofalse(i.e. default behaviour is the same). When set totruethe same secretName as for the subdomain based ingresses will be used then.ingress.certManagerAnnotations. This is useful when the certifcates won't be managed by cert-manager at all. Default is stilltrue.hosts.additionalWildcardInstancesto instances. This is required when the certificates shall be managed via cert-manager, so that all possible paths are already available in the ingress and therefore included in the requests of the cert-manager.Also see https://github.com/eclipsesource/theia-cloud/pull/298 (also contains testing instructions)
eclipsesource/theia-cloud#296