Conversation
Contributed on behalf of STMicroelectronics
Introduce step that checks the version so we can use the information in the IF statment of jobs. Unfortunately ENVs are not available there, hence the workaround. Queue monitor-vscode after theia-cloud-demo so they can be build together with one run. Automate the detection of the version for the demo flow. Now there is no need to specify on how they should be published. Contributed on behalf of STMicroelectronics
Remove `node/monitor` from the workspaces setup, because `vsce` is incompatible with it. Still build the extension together with other packages. Provide quick command to update the extension in the demo. Update extension in demo. Remove duplicate settings. Fix linting setup and lint packages that were not linted. Fix minor linting issues. Make tsconfigs more clear. Adjust try-now-page dockerfile to still work Contributed on behalf of STMicroelectronics
sgraband
force-pushed
the
fixNextBuild
branch
from
f97c95a to
548c937
Compare
jfaltermeier
reviewed
Feb 7, 2024
Contributor
jfaltermeier
left a comment
jfaltermeier
left a comment
There was a problem hiding this comment.
Looks very good, I only have a small comment
Contributor
There was a problem hiding this comment.
I think this file should be formatted once to remove the tabs that were introduced, e.g. in front of the webpack script
jfaltermeier
approved these changes
Feb 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to 0.10.0-next
Do not build on full release main pushes
Introduce step that checks the version so we can use the information in the IF statment of jobs.
Unfortunately ENVs are not available there, hence the workaround.
Queue monitor-vscode after theia-cloud-demo so they can be build together with one run.
Automate the detection of the version for the demo flow.
Now there is no need to specify on how they should be published.
Fix bundling of monitor extension
Remove
node/monitorfrom the workspaces setup, becausevsceis incompatible with it.Still build the extension together with other packages.
Provide quick command to update the extension in the demo.
Update extension in demo.
Remove duplicate settings.
Fix linting setup and lint packages that were not linted.
Fix minor linting issues.
Make tsconfigs more clear.
Contributed on behalf of STMicroelectronics