Merged
Conversation
This field can be used by adopters to pass arbitrary data to the operator. Field is added to all three CRDs for maximum configurability. Bumped version number for the CRDs and adjusted the conversion webhook.
jfaltermeier
approved these changes
Apr 12, 2024
Contributor
jfaltermeier
left a comment
jfaltermeier
left a comment
There was a problem hiding this comment.
LGTM! I've only briefly tested adding options to sessions which worked, so I think the other CRs should be fine as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This field can be used by adopters to pass arbitrary data to the operator.
Field is added to all three CRDs for maximum configurability.
Bumped version number for the CRDs and adjusted the conversion webhook.
Helm repo PR: https://github.com/eclipsesource/theia-cloud-helm/pull/55