Fix lastActivity not being initialized properly#354
Merged
Conversation
Contributor
sgraband
commented
Sep 27, 2024
sgraband
commented
- Improve and document debugging of operator and service
- Minor improvement: Local testing values should only pull IfNotPresent
- Fix lastActivity not being initialized properly
- We need to set it after the resource has been created.
- Therefore it is now handled by the operator not the service.
- Add warning in case resources are edited before being applied to the cluster.
- Only check HANDLED sessions from the activity tracking.
- Other resources should be cleaned up differently.
I would assume that this is the most common use case.
We need to set it after the resource has been created. Therefore it is now handled by the operator not the service. Add warning in case resources are edited before being applied to the cluster. Only check HANDLED sessions from the activity tracking. Other resources should be cleaned up differently.
Contributor
Author
|
@lucas-koehler Could you review this? |
lucas-koehler
approved these changes
Sep 27, 2024
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Hi @sgraband the code changes and the updated documentation look good to me ✨ I added two small non-blocking remarks inline
....operator/src/main/java/org/eclipse/theia/cloud/operator/plugins/MonitorActivityTracker.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for the comments/suggestions @lucas-koehler. I added both of them. Could you take another quick look? |
lucas-koehler
approved these changes
Oct 1, 2024
Contributor
lucas-koehler
left a comment
lucas-koehler
left a comment
There was a problem hiding this comment.
Thanks for the updates. LGTM ❇️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.