GH-349: Extend service with a list app definitions endpoint#361
Merged
lucas-koehler merged 1 commit intomainfrom Oct 23, 2024
Merged
GH-349: Extend service with a list app definitions endpoint#361lucas-koehler merged 1 commit intomainfrom
lucas-koehler merged 1 commit intomainfrom
Conversation
### App definition endpoint - Add AppDefinitionResource with endpoint to list all app definitions. The endpoint is restricted to authenticated users but is still available in anonymous mode ### Sensitive data redaction - Add `SensitiveData` annotation to mark properties that should not be serialized publicly by Jackson. - Add a corresponding serializer and serializer modifiert for Jackson and register the modifier in the service - Add unit tests for the serializer ### Javascript API - Update openapi.json from service - Regenerate api code - Add AppDefinitions namespace with function to list app definitions ### Testing Page - Add button to get app definitions - Apply formatting rules to App.tsx by saving it - Minor fix in example keycloak URL to remove obsolete `/auth` ### Misc - Add mockito dependency to the common maven module
jfaltermeier
approved these changes
Oct 23, 2024
Contributor
There was a problem hiding this comment.
Looks good to me. Passwords (and missing passwords) are both shown as ***.
Missing values are displayed as null, which is fine.
Nested objects, like monitor, also look good.
Without keycloak, listing app definitions still works.
With keycloak only logged in users can list app definitions.
I just added one question inline out of curiosity - maybe you have an answer.
...org/eclipse/theia/cloud/service/serialization/SensitiveDataCustomSerializerRegistration.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
App definition endpoint
Sensitive data redaction
SensitiveDataannotation to mark properties that should not be serialized publicly by Jackson.Javascript API
Testing Page
/authMisc
How to test
pullSecretproperties have value***which is the redacted value