Create missing internal services in eager start app definition handler // Prepare 1.1.1#441
Merged
jfaltermeier merged 2 commits intomainfrom Aug 1, 2025
Merged
Create missing internal services in eager start app definition handler // Prepare 1.1.1#441jfaltermeier merged 2 commits intomainfrom
jfaltermeier merged 2 commits intomainfrom
Conversation
* add logic to create and apply internal services for missing instances
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eager mode is still not production ready, but we want to support pre-launching pods and assigning this fixed set of pre-launched pods to users. This PR adds the required internal service for that.
Eager mode still has lots of limitations that are not addressed with this PR, e.g. starting additional pods when all eager started pods are used, or a mixed mode with lazy start.
Also prepares this fix as a 1.1.1 release.