Added detailed description about extension types#186
Conversation
b12490c to
7cc9a41
Compare
There was a problem hiding this comment.
Please update the commit message, there are currently typos:
Added detailled description about extenssion types
Added detailed descriptions about extension types
I think there is still some work to be done regarding the overall content of the documentation added to make it clearer and more informative.
There was a problem hiding this comment.
It would be great if the new image for extensions depicts:
- How @Theia extensions can contribute to FE and BE
- FE and BE run on different processes (and even different hosts)
- Vscode extensions and Theia plugins run in a separate process (extension host)
- The illustration can hopefully reflect the RPC communication lines between FE and BE, and FE to extensions host (via BE).
- There is a one to one relationship between the number of FE and number of plugin hosts.
The above took me sometime to understand and hopefully it would be useful for others,
I hope I got it right :-)
Will do when I do the final squash |
I agree, all your points should be documented. However, I do not want to overload the diagram here, it is already a little more complex then I wanted it to be. This article is really meant as an overview. I believe your suggestion should go into a section called "architecture" or "extension architecture". Would you mind to paste your suggestion into a separate ticket? |
I have created the following issues as per your suggestion: ##186 (comment) |
|
@vince-fugnitto : Are you waiting for Marcs review or are we good to go here? |
fixed #158 Contributed on behalf of STMicroelectronics Signed-off-by: Jonas Helming <jhelming@eclipsesource.com>
Done! |
vince-fugnitto
left a comment
There was a problem hiding this comment.
I believe the changes are fine for the moment and provide additional details as to what exists currently 👍 We can always re-visit the documentation to go more in depth (and possibly technical) in future iterations.
fixed #185
Contributed on behalf of STMicroelectronics
Signed-off-by: Jonas Helming jhelming@eclipsesource.com