Skip to content

Commit a8984c2

Browse files
paul-marechalRomanNikitenko
authored andcommitted
upgrade to inversify@^5.1.1 (#9979)
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
1 parent 099f830 commit a8984c2

File tree

4 files changed

+7
-6
lines changed

4 files changed

+7
-6
lines changed

doc/Migration.md

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,10 @@ Please see the latest version (`master`) for the most up-to-date information.
2525
}
2626
}
2727
});
28-
```
28+
```
2929
- Replace the targets with the ones that are needed for your use case
30+
- Make sure to use `inversify@5.1.1`. Theia requires `inversify@^5.0.1` which means that `5.1.1` is compatible,
31+
but your lockfile might reference an older version.
3032
3133
### v1.16.0
3234
@@ -46,7 +48,7 @@ Please see the latest version (`master`) for the most up-to-date information.
4648
- Arch Linux: `sudo pacman -S libsecret`
4749
- Alpine: `apk add libsecret-dev`
4850
- It is possible that a `yarn resolution` is necessary for `keytar` to work on older distributions (the fix was added in `1.16.0` by downgrading the dependency version):
49-
51+
5052
```json
5153
"resolutions": {
5254
"**/keytar": "7.6.0",
@@ -73,4 +75,3 @@ Please see the latest version (`master`) for the most up-to-date information.
7375
"**/webpack": "5.46.0",
7476
}
7577
```
76-

packages/core/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ export class SomeClass {
8585
- [`express@^4.16.3`](https://www.npmjs.com/package/express)
8686
- [`fs-extra@^4.0.2`](https://www.npmjs.com/package/fs-extra)
8787
- [`fuzzy@^0.1.3`](https://www.npmjs.com/package/fuzzy)
88-
- [`inversify@^5.0.1`](https://www.npmjs.com/package/inversify)
88+
- [`inversify@^5.1.1`](https://www.npmjs.com/package/inversify)
8989
- [`lodash.debounce@^4.0.8`](https://www.npmjs.com/package/lodash.debounce)
9090
- [`lodash.throttle@^4.1.1`](https://www.npmjs.com/package/lodash.throttle)
9191
- [`nsfw@^2.1.2`](https://www.npmjs.com/package/nsfw)

packages/core/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"fs-extra": "^4.0.2",
4646
"fuzzy": "^0.1.3",
4747
"iconv-lite": "^0.6.0",
48-
"inversify": "^5.0.1",
48+
"inversify": "^5.1.1",
4949
"jschardet": "^2.1.1",
5050
"keytar": "7.2.0",
5151
"lodash.debounce": "^4.0.8",

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5800,7 +5800,7 @@ interpret@^2.2.0:
58005800
resolved "https://registry.yarnpkg.com/interpret/-/interpret-2.2.0.tgz#1a78a0b5965c40a5416d007ad6f50ad27c417df9"
58015801
integrity sha512-Ju0Bz/cEia55xDwUWEa8+olFpCiQoypjnQySseKtmjNrnps3P+xfpUmGr90T7yjlVJmOtybRvPXhKMbHr+fWnw==
58025802

5803-
inversify@^5.0.1:
5803+
inversify@^5.1.1:
58045804
version "5.1.1"
58055805
resolved "https://registry.yarnpkg.com/inversify/-/inversify-5.1.1.tgz#6fbd668c591337404e005a1946bfe0d802c08730"
58065806
integrity sha512-j8grHGDzv1v+8T1sAQ+3boTCntFPfvxLCkNcxB1J8qA0lUN+fAlSyYd+RXKvaPRL4AGyPxViutBEJHNXOyUdFQ==

0 commit comments

Comments
 (0)