Merged
Conversation
paul-marechal
added
bug
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
paul-marechal
force-pushed
the
mp/inversify-5.1.1
branch
from
a3958ff to
880b1ff
Compare
paul-marechal
added a commit
that referenced
this pull request
Aug 31, 2021
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
RomanNikitenko
pushed a commit
that referenced
this pull request
Sep 16, 2021
Since we changed our TypeScript compilation target from ES5 to ES2017 there is a bug with `inversify` prior to version `5.1.1` leading to the frontend application not starting. We expected issues with `inversify` when targeting ES2017 but couldn't find it in the end. This is because we are pulling a version of `inversify` that did not cause the problem. This commit updates the `inversify` range to pull a working version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we changed our TypeScript compilation target from ES5 to ES2017
there is a bug with
inversifyprior to version5.1.1leading tothe frontend application not starting.
We expected issues with
inversifywhen targeting ES2017 but couldn'tfind it in the end. This is because we are pulling a version of
inversifythat did not cause the problem.This commit updates the
inversifyrange to pull a working version.How to test
If you want to reproduce the issue you can add a resolution field such as
"**/inversify": "5.0.1"and runyarn.Using
inversify@5.0.1will cause the frontend to crash on startup.The problem is fixed when using
inversify@5.1.1.Review checklist
Reminder for reviewers