support hiding the status bar

[EstherPerelman]

Signed-off-by: Esther Perelman esther.perelman@sap.com

What it does

This PR supports hiding the status bar (blue bar on the bottom) in 2 ways:

1. By selecting the Toggle status Bar command from the view menu:
   

2. By updating the workbench.statusBar.visible setting in the preferences file.
   

How to test

• Validate that the status bar appears for the first time,
• Play around with the 2 ways mentions above...

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[EstherPerelman]

@vince-fugnitto can you help me to solve the issue causes the builds to fail, The problem is with the injection of the PreferenceService to the status-bar.tsx I guess I need to change some code in theia\packages\core\src\browser\keybinding.spec.ts but I don't know how to do it (I'm not so familiar with inversify)
Actually I used the corePreferences but changed to PreferenceService during the tries to solve this problem, It will be better if you give me a solution for it... Thanks in advance!

[vince-fugnitto]

@vince-fugnitto can you help me to solve the issue causes the builds to fail...

@EstherPerelman you can try the following file to resolve the test bindings:

https://gist.github.com/vince-fugnitto/19456daac6167c2f3ec71626050ba1a7

[EstherPerelman]

@EstherPerelman you can try the following file to resolve the test bindings:

https://gist.github.com/vince-fugnitto/19456daac6167c2f3ec71626050ba1a7

@vince-fugnitto thank you for the clear and perfect solution!

[msujew]

The changes look good to me and I can confirm that everything works as expected:

• Toggling the status bar using the menu entry/command/keyboard shortcut
• Toggling the status bar using the preferences

[EstherPerelman]

@vince-fugnitto, Thank you for the comments, I've uploaded the fixes and replied to this comment, Please merge it if possible...

[vince-fugnitto]

The functionality of the changes work well for me 👍
I have a minor comment about adding a changelog entry.

[EstherPerelman]

The functionality of the changes work well for me 👍
I have a minor comment about adding a changelog entry.

@vince-fugnitto thank you, I have updated the CHANGELOG.md

[vince-fugnitto]

The changes look good to me 👍
I confirmed that:

• the preference works well
• using the command properly toggles the statusbar and updates the preference

[EstherPerelman]

The changes look good to me 👍 I confirmed that:

• the preference works well
• using the command properly toggles the statusbar and updates the preference

@vince-fugnitto This PR is quite necessary for us, If it will be merged for tomorrow it will help us (this not seem to be so big change, don't you think like?)