fix open dialog when workspace directory is deleted#10171
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Oct 6, 2021
shuyaqian:fix-open-dialog
Merged
fix open dialog when workspace directory is deleted#10171msujew merged 1 commit intoeclipse-theia:masterfrom shuyaqian:fix-open-dialog
msujew merged 1 commit intoeclipse-theia:masterfrom
shuyaqian:fix-open-dialog
Conversation
msujew
approved these changes
Sep 27, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by the changes nicely.
packages/filesystem/src/browser/file-dialog/file-dialog-service.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: shuyaqian 717749594@qq.com
Member
|
@msujew do we want to add the pr to the release? |
Member
|
@vince-fugnitto Sure, I don't see a lot of possible regressions with this one 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: shuyaqian 717749594@qq.com
What it does
fix #10170
How to test
Review checklist
Reminder for reviewers