Merged
Conversation
`lerna@4` follows lifecycle scripts when running publish: https://github.com/lerna/lerna/tree/main/commands/publish#lifecycle-scripts We never relied on those, and it also causes issues with our setup. Add `--ignore-scripts` to prevent script recursion.
Contributor
|
We might also need to add an option for lerna to go ahead and publish despite the uncommitted change to the various package.json files: #10175 (comment) |
Contributor
|
Maybe this: lerna/lerna#1700 (comment) |
marcdumais-work
approved these changes
Sep 28, 2021
Contributor
marcdumais-work
left a comment
marcdumais-work
left a comment
There was a problem hiding this comment.
Not sure it will fix all our issues, but I noticed the extra scripts being called and it's a good step forward to get rid of them.
Contributor
|
I used this PR in a local registry (verdaccio) and was able to successfully publish. Let's merge and see if it also works in CI! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
lerna@4follows lifecycle scripts when running publish:https://github.com/lerna/lerna/tree/main/commands/publish#lifecycle-scripts
We never relied on those, and it also causes issues with our setup.
Add
--ignore-scriptsto prevent script recursion.