Expand variables in env section of tasks.json#10208
Merged
paul-marechal merged 2 commits intoeclipse-theia:masterfrom Nov 25, 2021
Merged
Expand variables in env section of tasks.json#10208paul-marechal merged 2 commits intoeclipse-theia:masterfrom
paul-marechal merged 2 commits intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@emilhammarstedtst thank you for your first contribution to the project 👍
Please be sure to rebase your branch against the latest master, it should resolve build problems you were experiencing, namely the untracked changes.
emilhammarstedtst
force-pushed
the
issue-#10207
branch
from
3699141 to
fc2566f
Compare
Contributor
Author
|
I do not know why the build failed as the Ubuntu pipeline only says "Error:" |
…ervice Fixes eclipse-theia#10207 Contributed by STMicroelectronics Signed-off-by: Emil HAMMARSTEDT <emil.hammarstedt@st.com>
paul-marechal
force-pushed
the
issue-#10207
branch
from
fc2566f to
6d48926
Compare
paul-marechal
approved these changes
Nov 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10207
Contributed by STMicroelectronics
Signed-off-by: Emil HAMMARSTEDT emil.hammarstedt@st.com
How to test
See issue #10207 for reproducing
Review checklist
Reminder for reviewers