Skip to content

Enforce debug content when EditorModel is invalid#10222

Merged
colin-grant-work merged 1 commit intomasterfrom
bugfix/double-add-configurations
Oct 5, 2021
Merged

Enforce debug content when EditorModel is invalid#10222
colin-grant-work merged 1 commit intomasterfrom
bugfix/double-add-configurations

Conversation

@colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Oct 4, 2021

What it does

Fixes #10159 by enforcing the addition of content when the editor is in an invalid state.

How to test

  1. Create a .theia/launch.json by clicking the Add Configuration... button on theRun menu.
  2. Delete the .theia folder manaually and close the editor.
  3. Click the Add Configuration menu item again.
  4. Observe that an editor is opened with the skeleton of the launch configuration.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant colin.grant@ericsson.com

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
@colin-grant-work colin-grant-work added the debug issues that related to debug functionality label Oct 4, 2021
@colin-grant-work colin-grant-work changed the title Enforce content when EditorModel is invalid Enforce debug content when EditorModel is invalid Oct 4, 2021
Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that the issue exists on master and the changes address it nicely 👍

@colin-grant-work colin-grant-work merged commit 1738469 into master Oct 5, 2021
@colin-grant-work colin-grant-work deleted the bugfix/double-add-configurations branch October 5, 2021 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

debug issues that related to debug functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can not re-create the .theia/launch.json a second time when the file is manually deleted.

2 participants