Enforce debug content when EditorModel is invalid#10222
Merged
colin-grant-work merged 1 commit intomasterfrom Oct 5, 2021
Merged
Enforce debug content when EditorModel is invalid#10222colin-grant-work merged 1 commit intomasterfrom
colin-grant-work merged 1 commit intomasterfrom
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
msujew
approved these changes
Oct 5, 2021
Member
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and the changes address it nicely 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10159 by enforcing the addition of content when the editor is in an invalid state.
How to test
launchconfiguration.Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com