Normalize and prefix windows paths with Path.separator#10226
Merged
msujew merged 1 commit intoeclipse-theia:masterfrom Nov 1, 2021
Merged
Normalize and prefix windows paths with Path.separator#10226msujew merged 1 commit intoeclipse-theia:masterfrom
msujew merged 1 commit intoeclipse-theia:masterfrom
Conversation
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
@emilhammarstedtst thank you for the contribution 👍
Would you mind adding additional tests to path.spec.ts to cover the new use-cases?
- Prefix path with / if on the form of "c:/" into "/c:/" - Normalize windows path-separator paths to use / instead of \\ - Added test section to test normalize windows styled paths with \ Contributed by STMicroelectronics Signed-off-by: Emil HAMMARSTEDT <emil.hammarstedt@st.com>
emilhammarstedtst
force-pushed
the
path-normalizing
branch
from
8f21a98 to
0b2686b
Compare
Member
|
@eclipse-theia/core any developers on windows that can help review this change? |
msujew
approved these changes
Oct 21, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by the changes:
2021-10-21.16-08-07.mp4
The changes look reasonable to me as well 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10225
How to test
Run any command that produces an output of windows-style-path in terminal and it should be clickable.
Review checklist
Reminder for reviewers
Contributed by STMicroelectronics
Signed-off-by: Emil HAMMARSTEDT emil.hammarstedt@st.com