editor: use full path for title captions

[vince-fugnitto]

What it does

Fixes: #10237

The pull-request updates the editor title caption to use the full path rather than the relative path from the label-provider which aligns with the behavior present in vscode. The full-path is especially useful in a multi-root workspace where two files with the same name could not be easily differentiated previously.

How to test

1. confirm that CI passes
2. start the application
3. open multiple editors - confirm that their full path is displayed when hovering over the tab-bar
4. open a multi-root workspace - open multiple editors from different roots - confirm that their full path is displayed when hovering over the tab-bar

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

[vince-fugnitto]

I'll need to take a look at the failures in the markers tests (which likely relies on the workspace label-provider).

[alvsan09]

I have tested as per the instructions provided and works as expected 👍

It would be great of you could also add steps to verify the changes to marker-tree-label-provider.ts .

[vince-fugnitto]

It would be great of you could also add steps to verify the changes to marker-tree-label-provider.ts .

The marker-tree-label-provider was updated in order to make it's tests (which cover multiple use-cases for single and multi-root) pass again since it used to rely on workspace-uri-label-provider to compute the label in a multi-root setting. The changes now handle the getLongName properly rather than depend on another label-provider.

[alvsan09]

It looks good to me !
Thanks Vince!

[colin-grant-work]

This is having negative effects on the 'disambiguator' when files with the same name are opened.

1. Create two folders that are grandchildren of the same folder

e.g. /a/b/c/d and /a/b/e/f

2. Add a file with the same name to both: /a/b/c/d/hello.txt and /a/b/e/f/hello.txt
3. Add folders d and f to a workspace and open both hello.txt files.
4. The disambiguator will use c and e as disambiguators, even though those are parents of the workspace folders.

[vince-fugnitto]

@colin-grant-work @alvsan09 I simplified the pull-request to not modify the workspace-uri-label-provider since it might have cascading consequences and instead use the full-path for the editor's title caption.

[colin-grant-work]

Hard to argue with simplicity.