[debug view] Fix restoring of selected configuration#10287
Merged
paul-marechal merged 2 commits intomasterfrom Oct 18, 2021
Merged
[debug view] Fix restoring of selected configuration#10287paul-marechal merged 2 commits intomasterfrom
paul-marechal merged 2 commits intomasterfrom
Conversation
msujew
approved these changes
Oct 18, 2021
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
I can confirm that the issue exists on master and is addressed by this change nicely 👍
The debug view has the functionality to save the currently selected debug configuration to local storage. However the restoring of it failed as the initialization of the debug configuration manager was not completed by the time the restore action was attempted. This change fixes the intended wait for initialization of the debug configuration manger. Signed-off-by: Alvaro Sanchez-Leon <alvaro.sanchez-leon@ericsson.com> Co-authored-by: Paul Maréchal <paul.marechal@ericsson.com>
alvsan09
force-pushed
the
asl/restore-selected-debug-config
branch
from
a6d0d99 to
ec4cef5
Compare
vince-fugnitto
approved these changes
Oct 18, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the debug configuration selection persists across sessions, and looks like an overall better solution that using the deferred 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #7918
The debug view has the functionality to save the currently selected
debug configuration to local storage.
However the restoring of it failed as the initialization of the
debug configuration manager was not completed by the time the restore
action was attempted.
This change fixes the intended wait for initialization of the debug
configuration manger.
How to test
Review checklist
Reminder for reviewers