Skip to content

repo: yarn upgrade following v1.19.0 release#10349

Merged
marcdumais-work merged 1 commit intomasterfrom
vf/yarn-upgrade-1.19.0
Nov 1, 2021
Merged

repo: yarn upgrade following v1.19.0 release#10349
marcdumais-work merged 1 commit intomasterfrom
vf/yarn-upgrade-1.19.0

Conversation

@vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Oct 28, 2021

What it does

The commit performs a yarn upgrade following the v1.19.0 release.

How to test

  • confirm that ci is green for the build and tests
  • confirm that the 3pp license check passes (may need to be updated - file updates to)

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com

@vince-fugnitto vince-fugnitto added the dependencies issues that plan to update dependencies label Oct 28, 2021
@vince-fugnitto vince-fugnitto self-assigned this Oct 28, 2021
The commit performs a `yarn upgrade` following the `v1.19.0` release.

Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
@vince-fugnitto
Copy link
Member Author

cc @marcdumais-work can we run the process to update clearly-defined with the updated dependencies?

@marcdumais-work
Copy link
Contributor

cc @marcdumais-work can we run the process to update clearly-defined with the updated dependencies?

yes, I can do that.

@marcdumais-work
Copy link
Contributor

Done - we'll see what happens.

@marcdumais-work
Copy link
Contributor

All new dependencies/versions have been approved, and the License check now passes locally.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI passes with all tests successfully and Theia passes manual inspection (manual smoke tests) 👍

@marcdumais-work
Copy link
Contributor

Let's merge this - thanks @vince-fugnitto

@marcdumais-work marcdumais-work merged commit bca6eda into master Nov 1, 2021
@marcdumais-work marcdumais-work deleted the vf/yarn-upgrade-1.19.0 branch November 1, 2021 15:15
@github-actions github-actions bot added this to the 1.20.0 milestone Nov 1, 2021
@marcdumais-work
Copy link
Contributor

The license check failed: https://github.com/eclipse-theia/theia/actions/runs/1408480659

I'll confirm locally and re-run in automated mode to attempt to clear this dependency

@marcdumais-work
Copy link
Contributor

ERROR: Found results that aren't part of the baseline!
X npm/npmjs/-/estraverse/5.3.0, BSD-2-Clause

@marcdumais-work
Copy link
Contributor

re-run in automated mode to attempt to clear this dependency

https://gitlab.eclipse.org/eclipsefdn/emo-team/iplab/-/issues/1557

@marcdumais-work
Copy link
Contributor

It's approved. It might take a little while, but the info will propagate and the license check will pass, if re-run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies issues that plan to update dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants