search-in-workspace: add noselect to line result nodes#10371
Merged
alvsan09 merged 1 commit intoeclipse-theia:masterfrom Nov 2, 2021
Merged
search-in-workspace: add noselect to line result nodes#10371alvsan09 merged 1 commit intoeclipse-theia:masterfrom
noselect to line result nodes#10371alvsan09 merged 1 commit intoeclipse-theia:masterfrom
Conversation
Archie27376
changed the title
noselect to line result nodes
Archie27376
force-pushed
the
SearchBar_NoSelect
branch
from
efaf732 to
c2ec989
Compare
The commit adds `noselect` to the line result nodes so thier inner text is not selectable, aligning with the rest of the framework and vscode.
Archie27376
force-pushed
the
SearchBar_NoSelect
branch
from
c2ec989 to
9a0d635
Compare
vince-fugnitto
added
search in workspace
vince-fugnitto
approved these changes
Nov 2, 2021
Member
vince-fugnitto
left a comment
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that t works well 👍
- the inner content for search-in-workspace line result nodes are no longer selectable
- the changes work well when searching in a multi-root workspace
- there is no regression when the node itself is selected
alvsan09
approved these changes
Nov 2, 2021
Contributor
alvsan09
left a comment
alvsan09
left a comment
There was a problem hiding this comment.
I can also confirm that the solution works well and no regressions were detected 👍
thanks @Archie27376 !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes: #10362
The commit adds
noselectto the line result nodes so their inner text isnot selectable, aligning with the rest of the framework and vscode.
How to test
Review checklist
Reminder for reviewers