dep: update compression-webpack-plugin#10391
Merged
vince-fugnitto merged 1 commit intomasterfrom Nov 8, 2021
Merged
Conversation
msujew
approved these changes
Nov 8, 2021
Member
msujew
left a comment
There was a problem hiding this comment.
The dependency update looks good to me 👍
- The dependency does not appear in the audit list anymore.
- Files continue to be served using a compressed format. (
content-encoding: gzip) - No additional build/bundling issues, Theia runs normally.
7afe74e to
c7022e7
Compare
The commit replaces the forked depedency `@theia/compression-webpack-plugin` which was not maintained in favor of the upstream dependency at the latest version. The original dependency was quite old, and contained security vulnerabilities. The `cache` option was preserved as it is now supported directly by webpack. Signed-off-by: vince-fugnitto <vincent.fugnitto@ericsson.com>
c7022e7 to
e62bde9
Compare
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request updates the use of
@theia/compression-webpack-plugin(an outdated fork) to it's upstream counterpart, since the former included security vulnerabilities.The
cacheis now a configuration option directly from webpack, and was removed as part ofcompression-webpack-plugin@7.0.0.How to test
yarn audit --level=highdoes not yield results forcompression-webpack-pluginexamples/browser/gen-webpack.config.js)examples/browser/lib/should contain*.gzcompressions such asbundle.js.gz*.gzfiles are not presentCompression Off
Review checklist
Reminder for reviewers
Signed-off-by: vince-fugnitto vincent.fugnitto@ericsson.com