Refactor to improve extensibility of ProcessTaskRunner#10392
Merged
colin-grant-work merged 2 commits intomasterfrom Nov 18, 2021
Merged
Refactor to improve extensibility of ProcessTaskRunner#10392colin-grant-work merged 2 commits intomasterfrom
colin-grant-work merged 2 commits intomasterfrom
Conversation
Member
paul-marechal
left a comment
paul-marechal
left a comment
There was a problem hiding this comment.
The refactoring looks good, just a few comments.
vince-fugnitto
added
extensibility
added 2 commits
November 17, 2021 10:14
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
colin-grant-work
force-pushed
the
feature/process-task-runner-extensibility
branch
from
ea6176e to
bc10ce4
Compare
colin-grant-work
deleted the
feature/process-task-runner-extensibility
branch
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Addresses (but doesn't fix) #8164 by making it easier to override specific parts of the
getResolvedCommandprocedure.How to test
Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com