fixed mini browser getSource uri#10481
Conversation
Signed-off-by: Aditya Sharma <aditya211935@gmail.com>
|
@vince-fugnitto I've accepted the terms. I didn't know that you had to login to eclipse to sign ECA. |
This comment has been minimized.
This comment has been minimized.
|
@aditya211935 thank you for signing the eca, everything looks in order 👍 |
|
@vince-fugnitto Any update on when it'll be merged? I can see that all workflow checks have passed. |
There was a problem hiding this comment.
@aditya211935 Thank you for your contribution. Contributions are merged after at least one approving review has been given (Merging usually happens one or two days after the approval for any other reviewers to object to the merge). See the review guidelines.
I confirmed that the issue exists on master and is addressed by your changes. Very clean solution 👍
- Opening the mini browser using the
Open URLcommand does not show theOpen Sourcetoolbar button. - Opening the mini browser by previewing a local html file shows the toolbar button and clicking it opens the original html file correctly.
|
@msujew Thanks! 👍 |
paul-marechal
left a comment
There was a problem hiding this comment.
Thanks for keeping the old checks.
Signed-off-by: Aditya Sharma aditya211935@gmail.com
What it does
Fixes: #10478
Since the URI passed to getSourceUri function doesn't have "http" or "https" scheme, and since a remote URL opened in preview mode doesn't have a a source URI on disk, a simple check is performed to check if the passed URI is equal to MiniBrowserOpenHandler's PREVIEW_URI static variable.
How to test
Review checklist
Reminder for reviewers