feat: add timestamp for DAP trace and formate output using JSON.stringify(message, null, 4)#10484
Merged
vince-fugnitto merged 5 commits intoeclipse-theia:masterfrom Dec 2, 2021
Merged
Conversation
Signed-off-by: bob <bob170731@gmail.com>
msujew
reviewed
Nov 29, 2021
Member
msujew
left a comment
There was a problem hiding this comment.
Hi @DanboDuan, thank you for your first contribution.
the improvement to logging looks good. I have a suggestion to simplify the change.
Signed-off-by: bob <bob170731@gmail.com>
Signed-off-by: bob <bob170731@gmail.com>
JSON.stringify(message, null, 4)
Signed-off-by: bob <bob170731@gmail.com>
vince-fugnitto
approved these changes
Dec 1, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
I confirmed that the changes work well, and the timestamp is now added to the traces of the debug adapter. Example:
ab3a895f 12/1/2021, 08:50:30.582 theia -> adapter: {
"seq": 34,
"type": "request",
"command": "scopes",
"arguments": {
"frameId": 34
}
}
Signed-off-by: bob <bob170731@gmail.com>
Member
|
@msujew any objections? :) |
msujew
approved these changes
Dec 2, 2021
Member
msujew
left a comment
There was a problem hiding this comment.
@vince-fugnitto None, looks good to me 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADD timestamp for DAP trace output
DAP trace output does not contain timestamp. it looks like this
It's not easy to get the performance with those trace output. It's better to output a timestamp so you will be easy to get a context.
How to test
check the dap trace output is now with timestamp like this
after the changes submit, check the dap trace output is now with timestamp like this
Review checklist
Reminder for reviewers