Support codicon icon references for plugin view containers#10491
Merged
colin-grant-work merged 1 commit intomasterfrom Nov 30, 2021
Merged
Support codicon icon references for plugin view containers#10491colin-grant-work merged 1 commit intomasterfrom
colin-grant-work merged 1 commit intomasterfrom
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
Contributor
Author
|
@msujew, since you've had a good look at various bits of Codicon related machinery recently, would you mind checking this out? |
msujew
approved these changes
Nov 30, 2021
Member
There was a problem hiding this comment.
Looks good to me 👍
- The codicon is correctly inserted into the class list for the tab icon
- The theme icon is visible in both sidebar and tab-item mode
- The svg-mask is not used when a
themeIconis present - Using masks still works correctly as expected (I used the Docker extension to test this)
Code looks reasonable, no complaints there.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10490 by implementing handling of
$(icon-name)strings for plugin view containers.How to test
vscode-references-viewfrom 47 to 81 in the builtin plugin manifest inpackage.jsonvscode-references-viewfrom yourpluginsfolder and runyarn buildFind All Referencesor find an interesting function and run the command palette commandCalls: Show Call Hierarchyvscode-reference-viewplugin view appears, and the plugin's view container has an icon and that that icon is styled like the rest of our Codicon view container icons.Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com