Skip to content

Support codicon icon references for plugin view containers#10491

Merged
colin-grant-work merged 1 commit intomasterfrom
feature/icon-references-for-view-containers
Nov 30, 2021
Merged

Support codicon icon references for plugin view containers#10491
colin-grant-work merged 1 commit intomasterfrom
feature/icon-references-for-view-containers

Conversation

@colin-grant-work
Copy link
Contributor

@colin-grant-work colin-grant-work commented Nov 29, 2021

What it does

Fixes #10490 by implementing handling of $(icon-name) strings for plugin view containers.

How to test

  1. Change the version of vscode-references-view from 47 to 81 in the builtin plugin manifest in package.json
  2. Delete any existing versions of vscode-references-view from your plugins folder and run yarn build
  3. Start the application with the Theia repo as your workspace.
  4. Find an interesting variable and run Find All References or find an interesting function and run the command palette command Calls: Show Call Hierarchy
  5. Observe that the vscode-reference-view plugin view appears, and the plugin's view container has an icon and that that icon is styled like the rest of our Codicon view container icons.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant colin.grant@ericsson.com

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
@colin-grant-work colin-grant-work added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Nov 29, 2021
@colin-grant-work
Copy link
Contributor Author

@msujew, since you've had a good look at various bits of Codicon related machinery recently, would you mind checking this out?

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

  • The codicon is correctly inserted into the class list for the tab icon
  • The theme icon is visible in both sidebar and tab-item mode
  • The svg-mask is not used when a themeIcon is present
  • Using masks still works correctly as expected (I used the Docker extension to test this)

Code looks reasonable, no complaints there.

@colin-grant-work colin-grant-work merged commit d9dc963 into master Nov 30, 2021
@colin-grant-work colin-grant-work deleted the feature/icon-references-for-view-containers branch November 30, 2021 14:39
@github-actions github-actions bot added this to the 1.21.0 milestone Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Codicon Icons in Plugin.contributes.viewsContainers

2 participants