Open plugin editor view on single click#10498
Merged
colin-grant-work merged 1 commit intomasterfrom Dec 2, 2021
Merged
Conversation
Signed-off-by: Colin Grant <colin.grant@ericsson.com>
vince-fugnitto
approved these changes
Dec 2, 2021
Member
vince-fugnitto
left a comment
There was a problem hiding this comment.
The changes work well for me 👍
- only a single-click is needed to open an editor
- editors are only opened once, if not already opened
- actions such as install do not require the extension to be active
- using the arrow keys and enter to open editors still works
- no visible regressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it does
This PR changes the event handling in the VSX tree views so that a single click on a tree node opens the editor view (main-panel view) for the plugin, and clicking on interactables within the node does not select the node. These changes bring us a bit closer to VSCode's behavior.
How to test
Review checklist
Reminder for reviewers
Signed-off-by: Colin Grant colin.grant@ericsson.com