Skip to content

Open plugin editor view on single click#10498

Merged
colin-grant-work merged 1 commit intomasterfrom
minor/open-plugin-view-on-single-click
Dec 2, 2021
Merged

Open plugin editor view on single click#10498
colin-grant-work merged 1 commit intomasterfrom
minor/open-plugin-view-on-single-click

Conversation

@colin-grant-work
Copy link
Contributor

What it does

This PR changes the event handling in the VSX tree views so that a single click on a tree node opens the editor view (main-panel view) for the plugin, and clicking on interactables within the node does not select the node. These changes bring us a bit closer to VSCode's behavior.

How to test

  1. Open the extensions view.
  2. Click on a tree node.
  3. Observe that the plugin editor view opens.
  4. Double click on a tree node.
  5. Observe that the plugin editor view opens only once (if it wasn't already open)
  6. Click on a button inside a non-selected node (gear, install, uninstall)
  7. Observe that the action associated with that button takes place, but the node is not selected.

Review checklist

Reminder for reviewers

Signed-off-by: Colin Grant colin.grant@ericsson.com

Signed-off-by: Colin Grant <colin.grant@ericsson.com>
@colin-grant-work colin-grant-work added ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration labels Dec 1, 2021
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work well for me 👍

  • only a single-click is needed to open an editor
  • editors are only opened once, if not already opened
  • actions such as install do not require the extension to be active
  • using the arrow keys and enter to open editors still works
  • no visible regressions

@colin-grant-work colin-grant-work merged commit 0be02b4 into master Dec 2, 2021
@colin-grant-work colin-grant-work deleted the minor/open-plugin-view-on-single-click branch December 2, 2021 15:50
@github-actions github-actions bot added this to the 1.21.0 milestone Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/ux issues related to user interface / user experience vsx-registry Issues related to Open VSX Registry Integration

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants